[GitHub] twalthr commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink

[GitBox <gi...@apache.org>]

twalthr commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438189527
 
 
   @yanghua I agree with @pnowojski. We should test Kafka and Elastic but we don't need to test them together. The `Executing SQL: Match recognize -> Elasticsearch` test was meant for testing the new `MATCH_RECOGNIZE` it must not use Elasticsearch or Kafka. I guess the reason why Kafka was chosen is because it is the only supported way of having time attributes in the SQL Client so far.
   
   I think we should split the current SQL client test into a Kafka 0.10 test and a main SQL Client test (that always uses the most recent Kafka version, ES version etc.). This means we don't have a test regression but don't test everything for every connector version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services