You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2021/04/01 07:37:55 UTC
[myfaces] branch 3.0.x updated: BackPort 3.0 MYFACES-4391:
Disabled/Readonly attributes render correct HTML
This is an automated email from the ASF dual-hosted git repository.
tandraschko pushed a commit to branch 3.0.x
in repository https://gitbox.apache.org/repos/asf/myfaces.git
The following commit(s) were added to refs/heads/3.0.x by this push:
new 4aa8031 BackPort 3.0 MYFACES-4391: Disabled/Readonly attributes render correct HTML
new c83b6fc Merge pull request #194 from melloware/MYFACES-4391-30
4aa8031 is described below
commit 4aa803191ff194715d9393a469a79fe7b7c91fb6
Author: melloware <me...@gmail.com>
AuthorDate: Wed Mar 31 10:37:28 2021 -0400
BackPort 3.0 MYFACES-4391: Disabled/Readonly attributes render correct HTML
---
.../apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java | 4 ++--
.../myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java | 2 +-
.../myfaces/shared/renderkit/html/HtmlInputFileRendererBase.java | 2 +-
.../apache/myfaces/shared/renderkit/html/HtmlRadioRendererBase.java | 2 +-
.../org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java | 2 +-
.../apache/myfaces/shared/renderkit/html/HtmlSecretRendererBase.java | 2 +-
.../myfaces/shared/renderkit/html/HtmlSelectableRendererBase.java | 2 +-
.../myfaces/shared/renderkit/html/HtmlTextareaRendererBase.java | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
index 6ade209..b006818 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlButtonRendererBase.java
@@ -280,13 +280,13 @@ public class HtmlButtonRendererBase
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE,
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR,
org.apache.myfaces.shared.renderkit.JSFAttr.DISABLED_ATTR);
}
if (isReadonly(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.READONLY_ATTR, Boolean.TRUE,
+ writer.writeAttribute(HTML.READONLY_ATTR, HTML.READONLY_ATTR,
org.apache.myfaces.shared.renderkit.JSFAttr.READONLY_ATTR);
}
}
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
index d9c14ab..7086108 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
@@ -463,7 +463,7 @@ public class HtmlCheckboxRendererBase extends HtmlRenderer
}
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.endElement(HTML.INPUT_ELEM);
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlInputFileRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlInputFileRendererBase.java
index 6a537a7..8cca24c 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlInputFileRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlInputFileRendererBase.java
@@ -231,7 +231,7 @@ public class HtmlInputFileRendererBase extends HtmlRenderer
if (isDisabled(facesContext, component))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (isAutocompleteOff(facesContext, component))
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRadioRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRadioRendererBase.java
index 2a3f779..4874dc9 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRadioRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRadioRendererBase.java
@@ -515,7 +515,7 @@ public class HtmlRadioRendererBase
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.endElement(HTML.INPUT_ELEM);
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
index da5419b..737ec40 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
@@ -526,7 +526,7 @@ public final class HtmlRendererUtils
if (disabled)
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (isReadOnly(uiComponent))
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSecretRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSecretRendererBase.java
index 9784070..7610d5f 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSecretRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSecretRendererBase.java
@@ -169,7 +169,7 @@ public class HtmlSecretRendererBase
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (isAutocompleteOff(facesContext, uiComponent))
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSelectableRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSelectableRendererBase.java
index 7918424..b236900 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSelectableRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlSelectableRendererBase.java
@@ -148,7 +148,7 @@ public class HtmlSelectableRendererBase extends HtmlRenderer
if (disabled)
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (HtmlRendererUtils.isReadOnly(uiComponent))
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextareaRendererBase.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextareaRendererBase.java
index f95b85e..03fd54c 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextareaRendererBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextareaRendererBase.java
@@ -154,7 +154,7 @@ public class HtmlTextareaRendererBase
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(org.apache.myfaces.shared.renderkit.html.HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
}