You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 13:41:09 UTC
[GitHub] [spark] yaooqinn opened a new pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
yaooqinn opened a new pull request #32351:
URL: https://github.com/apache/spark/pull/32351
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In this PR, we add extract/date_part support for ANSI Intervals
The `extract` is an ANSI expression and `date_part` is NON-ANSI but exists as an equivalence for `extract`
#### expression
```
<extract expression> ::=
EXTRACT <left paren> <extract field> FROM <extract source> <right paren>
```
#### <extract field> for interval source
```
<primary datetime field> ::=
<non-second primary datetime field>
| SECOND
<non-second primary datetime field> ::=
YEAR
| MONTH
| DAY
| HOUR
| MINUTE
```
#### dataType
```
If <extract field> is a <primary datetime field> that does not specify SECOND or <extract field> is not a <primary datetime field>, then the declared type of the result is an implementation-defined exact numeric type with scale 0 (zero)
Otherwise, the declared type of the result is an implementation-defined exact numeric type with scale not less than the specified or implied <time fractional seconds precision> or <interval fractional seconds precision>, as appropriate, of the SECOND <primary datetime field> of the <extract source>.
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Subtask of ANSI Intervals Support
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes
1. extract/date_part support ANSI intervals
2. for non-ansi intervals, the return type is changed from long to byte
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620898801
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,67 +29,105 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class ExtractANSIIntervalYears(child: Expression)
+ extends ExtractIntervalPart[Int](IntegerType, getYears, "getYears") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalYears =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMonths(child: Expression)
+ extends ExtractIntervalPart[Int](ByteType, getMonths, "getMonths") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMonths =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalDays(child: Expression)
+ extends ExtractIntervalPart[Long](IntegerType, getDays, "getDays") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalDays = {
+ copy(child = newChild)
+ }
+}
+
+case class ExtractANSIIntervalHours(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getHours, "getHours") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalHours =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMinutes(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getMinutes, "getMinutes") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMinutes =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalSeconds(child: Expression)
+ extends ExtractIntervalPart[Long](DecimalType(8, 6), getSeconds, "getSeconds") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalSeconds =
+ copy(child = newChild)
+}
+
object ExtractIntervalPart {
def parseExtractField(
extractField: String,
source: Expression,
errorHandleFunc: => Nothing): Expression = extractField.toUpperCase(Locale.ROOT) match {
+ case "YEAR" if source.dataType == YearMonthIntervalType => ExtractANSIIntervalYears(source)
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827287500
**[Test build #137979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137979/testReport)** for PR 32351 at commit [`e4bc0f6`](https://github.com/apache/spark/commit/e4bc0f625d10410750cd9bed7e01e28a3649023b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827380457
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827303783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42499/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620828995
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,67 +29,105 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class ExtractANSIIntervalYears(child: Expression)
+ extends ExtractIntervalPart[Int](IntegerType, getYears, "getYears") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalYears =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMonths(child: Expression)
+ extends ExtractIntervalPart[Int](ByteType, getMonths, "getMonths") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMonths =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalDays(child: Expression)
+ extends ExtractIntervalPart[Long](IntegerType, getDays, "getDays") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalDays = {
+ copy(child = newChild)
+ }
+}
+
+case class ExtractANSIIntervalHours(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getHours, "getHours") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalHours =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMinutes(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getMinutes, "getMinutes") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMinutes =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalSeconds(child: Expression)
+ extends ExtractIntervalPart[Long](DecimalType(8, 6), getSeconds, "getSeconds") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalSeconds =
+ copy(child = newChild)
+}
+
object ExtractIntervalPart {
def parseExtractField(
extractField: String,
source: Expression,
errorHandleFunc: => Nothing): Expression = extractField.toUpperCase(Locale.ROOT) match {
+ case "YEAR" if source.dataType == YearMonthIntervalType => ExtractANSIIntervalYears(source)
Review comment:
For ANSI compliance, I didn't add the abbreviations. For inner consistency, I am OK to add them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620791680
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -98,6 +130,19 @@ object ExtractIntervalPart {
case "SECOND" | "S" | "SEC" | "SECONDS" | "SECS" => ExtractIntervalSeconds(source)
case _ => errorHandleFunc
}
+
+ def parseExtractFieldANSI(
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827052722
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620898530
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,74 +29,126 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class ExtractANSIIntervalYears(child: Expression)
+ extends ExtractIntervalPart[Int](IntegerType, getYears, "getYears") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalYears =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMonths(child: Expression)
+ extends ExtractIntervalPart[Int](ByteType, getMonths, "getMonths") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMonths =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalDays(child: Expression)
+ extends ExtractIntervalPart[Long](IntegerType, getDays, "getDays") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalDays = {
+ copy(child = newChild)
+ }
+}
+
+case class ExtractANSIIntervalHours(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getHours, "getHours") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalHours =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMinutes(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getMinutes, "getMinutes") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMinutes =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalSeconds(child: Expression)
+ extends ExtractIntervalPart[Long](DecimalType(8, 6), getSeconds, "getSeconds") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalSeconds =
+ copy(child = newChild)
+}
+
object ExtractIntervalPart {
def parseExtractField(
extractField: String,
source: Expression,
- errorHandleFunc: => Nothing): Expression = extractField.toUpperCase(Locale.ROOT) match {
- case "YEAR" | "Y" | "YEARS" | "YR" | "YRS" => ExtractIntervalYears(source)
- case "MONTH" | "MON" | "MONS" | "MONTHS" => ExtractIntervalMonths(source)
- case "DAY" | "D" | "DAYS" => ExtractIntervalDays(source)
- case "HOUR" | "H" | "HOURS" | "HR" | "HRS" => ExtractIntervalHours(source)
- case "MINUTE" | "M" | "MIN" | "MINS" | "MINUTES" => ExtractIntervalMinutes(source)
- case "SECOND" | "S" | "SEC" | "SECONDS" | "SECS" => ExtractIntervalSeconds(source)
- case _ => errorHandleFunc
+ errorHandleFunc: => Nothing): Expression = {
+ (extractField.toUpperCase(Locale.ROOT), source.dataType) match {
+ case ("YEAR" | "Y" | "YEARS" | "YR" | "YRS", YearMonthIntervalType) =>
Review comment:
match the field and type both, so that we don't need to do type checking in all the `ExtractXXX` implementations, and reduce the code diff when removing CalendarIntervalType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826879737
**[Test build #137964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137964/testReport)** for PR 32351 at commit [`c4d957b`](https://github.com/apache/spark/commit/c4d957b063ac64cbd74c593072b97537b56737b9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827283421
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827268063
**[Test build #137975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137975/testReport)** for PR 32351 at commit [`db74496`](https://github.com/apache/spark/commit/db744963bde1ac6ceae6ba9d42f961654d7d5613).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827286547
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827269014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826886966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827383777
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620791633
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,61 +29,93 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class YearsOfYMInterval(child: Expression)
Review comment:
make sense, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620458985
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,61 +29,93 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class YearsOfYMInterval(child: Expression)
Review comment:
The name is a bit confusing. How about `ExtractANSIIntervalYears `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827300152
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42499/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826886966
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42484/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620460545
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -98,6 +130,19 @@ object ExtractIntervalPart {
case "SECOND" | "S" | "SEC" | "SECONDS" | "SECS" => ExtractIntervalSeconds(source)
case _ => errorHandleFunc
}
+
+ def parseExtractFieldANSI(
Review comment:
Can we merge this into `parseExtractField`?
```
case "YEAR" | "Y" | "YEARS" | "YR" | "YRS" =>
if (source.dataType == YearMonthIntervalType) {
ExtractANSIIntervalYears(source)
} else {
ExtractIntervalYears(source)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827268063
**[Test build #137975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137975/testReport)** for PR 32351 at commit [`db74496`](https://github.com/apache/spark/commit/db744963bde1ac6ceae6ba9d42f961654d7d5613).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826879737
**[Test build #137964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137964/testReport)** for PR 32351 at commit [`c4d957b`](https://github.com/apache/spark/commit/c4d957b063ac64cbd74c593072b97537b56737b9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827041469
**[Test build #137963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137963/testReport)** for PR 32351 at commit [`e0ac000`](https://github.com/apache/spark/commit/e0ac0005911d3da2b4246d91063a8896006ba39c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class ExtractIntervalPart[T](`
* `case class YearsOfYMInterval(child: Expression)`
* `case class MonthsOfYMInterval(child: Expression)`
* `case class DaysOfDTInterval(child: Expression)`
* `case class HoursOfDTInterval(child: Expression)`
* `case class MinutesOfDTInterval(child: Expression)`
* `case class SecondsOfDTInterval(child: Expression)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826886931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826847027
**[Test build #137963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137963/testReport)** for PR 32351 at commit [`e0ac000`](https://github.com/apache/spark/commit/e0ac0005911d3da2b4246d91063a8896006ba39c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826848638
cc @MaxGekk @cloud-fan @maropu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827381006
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827086783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137964/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827592094
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827365445
**[Test build #137979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137979/testReport)** for PR 32351 at commit [`e4bc0f6`](https://github.com/apache/spark/commit/e4bc0f625d10410750cd9bed7e01e28a3649023b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827383777
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827268999
**[Test build #137975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137975/testReport)** for PR 32351 at commit [`db74496`](https://github.com/apache/spark/commit/db744963bde1ac6ceae6ba9d42f961654d7d5613).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class ExtractANSIIntervalYears(child: Expression)`
* `case class ExtractANSIIntervalMonths(child: Expression)`
* `case class ExtractANSIIntervalDays(child: Expression)`
* `case class ExtractANSIIntervalHours(child: Expression)`
* `case class ExtractANSIIntervalMinutes(child: Expression)`
* `case class ExtractANSIIntervalSeconds(child: Expression)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827349805
**[Test build #137985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137985/testReport)** for PR 32351 at commit [`687a384`](https://github.com/apache/spark/commit/687a384afe914c1ed4688f64a20cf8f923919e53).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827303783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42499/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827534181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137985/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827052722
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827071804
**[Test build #137964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137964/testReport)** for PR 32351 at commit [`c4d957b`](https://github.com/apache/spark/commit/c4d957b063ac64cbd74c593072b97537b56737b9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620892697
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -98,6 +130,19 @@ object ExtractIntervalPart {
case "SECOND" | "S" | "SEC" | "SECONDS" | "SECS" => ExtractIntervalSeconds(source)
case _ => errorHandleFunc
}
+
+ def parseExtractFieldANSI(
Review comment:
we need another branch for DayTimeIntervalType case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826847027
**[Test build #137963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137963/testReport)** for PR 32351 at commit [`e0ac000`](https://github.com/apache/spark/commit/e0ac0005911d3da2b4246d91063a8896006ba39c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827349805
**[Test build #137985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137985/testReport)** for PR 32351 at commit [`687a384`](https://github.com/apache/spark/commit/687a384afe914c1ed4688f64a20cf8f923919e53).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827086783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137964/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826856665
thanks for reminding @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826928562
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42485/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32351:
URL: https://github.com/apache/spark/pull/32351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827512005
**[Test build #137985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137985/testReport)** for PR 32351 at commit [`687a384`](https://github.com/apache/spark/commit/687a384afe914c1ed4688f64a20cf8f923919e53).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620894130
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,67 +29,105 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class ExtractANSIIntervalYears(child: Expression)
+ extends ExtractIntervalPart[Int](IntegerType, getYears, "getYears") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalYears =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMonths(child: Expression)
+ extends ExtractIntervalPart[Int](ByteType, getMonths, "getMonths") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMonths =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalDays(child: Expression)
+ extends ExtractIntervalPart[Long](IntegerType, getDays, "getDays") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalDays = {
+ copy(child = newChild)
+ }
+}
+
+case class ExtractANSIIntervalHours(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getHours, "getHours") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalHours =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMinutes(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getMinutes, "getMinutes") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMinutes =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalSeconds(child: Expression)
+ extends ExtractIntervalPart[Long](DecimalType(8, 6), getSeconds, "getSeconds") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalSeconds =
+ copy(child = newChild)
+}
+
object ExtractIntervalPart {
def parseExtractField(
extractField: String,
source: Expression,
errorHandleFunc: => Nothing): Expression = extractField.toUpperCase(Locale.ROOT) match {
+ case "YEAR" if source.dataType == YearMonthIntervalType => ExtractANSIIntervalYears(source)
Review comment:
let's add them. We will use the new interval types by default and this is a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827534181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137985/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827269014
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137975/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827287500
**[Test build #137979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137979/testReport)** for PR 32351 at commit [`e4bc0f6`](https://github.com/apache/spark/commit/e4bc0f625d10410750cd9bed7e01e28a3649023b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827381006
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826921952
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42485/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-826848638
cc @MaxGekk @cloud-fan @maropu thanks very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827284834
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32351:
URL: https://github.com/apache/spark/pull/32351#discussion_r620824798
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -29,67 +29,105 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.CalendarInterval
-abstract class ExtractIntervalPart(
- child: Expression,
+abstract class ExtractIntervalPart[T](
val dataType: DataType,
- func: CalendarInterval => Any,
- funcName: String)
- extends UnaryExpression with ExpectsInputTypes with NullIntolerant with Serializable {
-
- override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType)
-
- override protected def nullSafeEval(interval: Any): Any = {
- func(interval.asInstanceOf[CalendarInterval])
- }
-
+ func: T => Any,
+ funcName: String) extends UnaryExpression with NullIntolerant with Serializable {
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
defineCodeGen(ctx, ev, c => s"$iu.$funcName($c)")
}
+
+ override protected def nullSafeEval(interval: Any): Any = {
+ func(interval.asInstanceOf[T])
+ }
}
case class ExtractIntervalYears(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getYears, "getYears") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getYears, "getYears") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalYears =
copy(child = newChild)
}
case class ExtractIntervalMonths(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMonths, "getMonths") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMonths =
copy(child = newChild)
}
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, IntegerType, getDays, "getDays") {
+ extends ExtractIntervalPart[CalendarInterval](IntegerType, getDays, "getDays") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalDays =
copy(child = newChild)
}
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, LongType, getHours, "getHours") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getHours, "getHours") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalHours =
copy(child = newChild)
}
case class ExtractIntervalMinutes(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getMinutes, "getMinutes") {
+ extends ExtractIntervalPart[CalendarInterval](ByteType, getMinutes, "getMinutes") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalMinutes =
copy(child = newChild)
}
case class ExtractIntervalSeconds(child: Expression)
- extends ExtractIntervalPart(child, DecimalType(8, 6), getSeconds, "getSeconds") {
+ extends ExtractIntervalPart[CalendarInterval](DecimalType(8, 6), getSeconds, "getSeconds") {
override protected def withNewChildInternal(newChild: Expression): ExtractIntervalSeconds =
copy(child = newChild)
}
+case class ExtractANSIIntervalYears(child: Expression)
+ extends ExtractIntervalPart[Int](IntegerType, getYears, "getYears") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalYears =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMonths(child: Expression)
+ extends ExtractIntervalPart[Int](ByteType, getMonths, "getMonths") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMonths =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalDays(child: Expression)
+ extends ExtractIntervalPart[Long](IntegerType, getDays, "getDays") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalDays = {
+ copy(child = newChild)
+ }
+}
+
+case class ExtractANSIIntervalHours(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getHours, "getHours") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalHours =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalMinutes(child: Expression)
+ extends ExtractIntervalPart[Long](ByteType, getMinutes, "getMinutes") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalMinutes =
+ copy(child = newChild)
+}
+
+case class ExtractANSIIntervalSeconds(child: Expression)
+ extends ExtractIntervalPart[Long](DecimalType(8, 6), getSeconds, "getSeconds") {
+ override protected def withNewChildInternal(newChild: Expression): ExtractANSIIntervalSeconds =
+ copy(child = newChild)
+}
+
object ExtractIntervalPart {
def parseExtractField(
extractField: String,
source: Expression,
errorHandleFunc: => Nothing): Expression = extractField.toUpperCase(Locale.ROOT) match {
+ case "YEAR" if source.dataType == YearMonthIntervalType => ExtractANSIIntervalYears(source)
Review comment:
Why don't we support all the shortcuts `"YEAR" | "Y" | "YEARS" | "YR" | "YRS"`? Can we merge the case?
```
case "YEAR" | "Y" | "YEARS" | "YR" | "YRS" => if (source.dataType == YearMonthIntervalType) ... else ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32351: [SPARK-35091][SPARK-35090][SQL] Support extract from ANSI Intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32351:
URL: https://github.com/apache/spark/pull/32351#issuecomment-827383747
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org