[GitHub] [calcite] rubenada commented on a change in pull request #2003: [CALCITE-4043] Improve IllegalArgumentException message in RelBuilder#field

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #2003:
URL: https://github.com/apache/calcite/pull/2003#discussion_r435229343



##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -487,8 +487,8 @@ public RexNode field(int inputCount, String alias, String fieldName) {
                 p.e.right.getName()));
       }
     }
-    throw new IllegalArgumentException("no aliased field found; fields are: "
-        + fields);
+    throw new IllegalArgumentException("{alias=" + alias + ",fieldName=" + fieldName + "} "

Review comment:
       Thanks for the feedback @hsyuan. I prefer to leave it as it is though, I am just using the same format that is being used a few lines before to store `fields` information.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org