You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/31 23:09:23 UTC
[GitHub] [maven] rosti-il opened a new pull request #304: Prevent printing
the EXEC_DIR when it's just a disk letter
rosti-il opened a new pull request #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304
This fixes following bug and also consistent with another 'cd /d "%EXEC_DIR%"' a few lines above.
When you're on the root of some disk running mvn.cmd prints an extra line with current dir before the correct output.
For example:
D:\>mvn -version
D:\
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: D:\develop\apache-maven-3.6.3\bin\..
Java version: 11.0.5, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.5
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rosti-il commented on issue #304: Prevent printing the
EXEC_DIR when it's just a disk letter
Posted by GitBox <gi...@apache.org>.
rosti-il commented on issue #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304#issuecomment-570476303
This pull request is approved two days ago. When will it be merged? I don't have a write access to this repository and so I can't merge it by myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] slachiewicz commented on issue #304: Prevent printing the
EXEC_DIR when it's just a disk letter
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on issue #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304#issuecomment-574104355
Thx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rosti-il commented on issue #304: Prevent printing the
EXEC_DIR when it's just a disk letter
Posted by GitBox <gi...@apache.org>.
rosti-il commented on issue #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304#issuecomment-574093831
Just created a Jira issue for this PR:
https://issues.apache.org/jira/browse/MNG-6850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on issue #304: Prevent printing the
EXEC_DIR when it's just a disk letter
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304#issuecomment-573873685
@rosti-il Please create a JIRA issue and I will merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] asfgit closed pull request #304: Prevent printing the
EXEC_DIR when it's just a disk letter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #304: Prevent printing the EXEC_DIR when it's just a disk letter
URL: https://github.com/apache/maven/pull/304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services