You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/06/01 08:55:38 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #6007: Copy fake icons before AJR is created
sdedic opened a new pull request, #6007:
URL: https://github.com/apache/netbeans/pull/6007
The build process is broken: the build creates fake icons for these for long time, but creates them after the jar is packaged. It works OK on dev machines, where ant clean is not routinely executed on whole nbcode project, but the build produced by apache CI is broken.
This PR hook to `-pre-jar` target, so the icons appear early enough to get packaged during 1st build as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] thurka commented on pull request #6007: Copy fake icons before JAR is created
Posted by "thurka (via GitHub)" <gi...@apache.org>.
thurka commented on PR #6007:
URL: https://github.com/apache/netbeans/pull/6007#issuecomment-1572498617
I tested the change and the icons are part of `org-netbeans-modules-nbcode-integration.jar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #6007: Copy fake icons before JAR is created
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #6007:
URL: https://github.com/apache/netbeans/pull/6007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists