You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zhjuzi (via GitHub)" <gi...@apache.org> on 2025/04/20 10:18:58 UTC
[PR] fix: listacl typo. resolves @issue9345 [rocketmq]
zhjuzi opened a new pull request, #9346:
URL: https://github.com/apache/rocketmq/pull/9346
### This PR Fixes
Fixes #9345
### Brief Description
This pull request fixes a typo in the option description of the ListAclSubCommand class.
Specifically, it changes "the resources of acl to filter." to use the correct word "resources" instead of the incorrect "resource" in the description for the -r/--resource option.
### How Did You Test This Change?
This change only modifies a string in the command-line option description, so no functional code is affected.
I verified the change by reviewing the help output of the command to ensure the description now displays correctly.
No additional tests are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: listacl typo. resolves @issue9345 [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9346:
URL: https://github.com/apache/rocketmq/pull/9346#issuecomment-2817444065
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9346?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 48.00%. Comparing base [(`854369a`)](https://app.codecov.io/gh/apache/rocketmq/commit/854369aa38ce574ccf931b99bdb799a6fb533183?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1b5c093`)](https://app.codecov.io/gh/apache/rocketmq/commit/1b5c09323a79d2dcaa805046b94c7344b0757203?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9346?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rocketmq/tools/command/auth/ListAclSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/9346?src=pr&el=tree&filepath=tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftools%2Fcommand%2Fauth%2FListAclSubCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYXV0aC9MaXN0QWNsU3ViQ29tbWFuZC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9346 +/- ##
=============================================
- Coverage 48.03% 48.00% -0.03%
+ Complexity 12139 12123 -16
=============================================
Files 1323 1323
Lines 93395 93395
Branches 11997 11997
=============================================
- Hits 44864 44836 -28
- Misses 42979 42993 +14
- Partials 5552 5566 +14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9346?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: listacl typo. resolves @issue9345 [rocketmq]
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on code in PR #9346:
URL: https://github.com/apache/rocketmq/pull/9346#discussion_r2051867983
##########
tools/src/main/java/org/apache/rocketmq/tools/command/auth/ListAclSubCommand.java:
##########
@@ -63,7 +63,7 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(false);
options.addOption(opt);
- opt = new Option("r", "resource", true, "the resource of acl to filter.");
+ opt = new Option("r", "resource", true, "the resources of acl to filter.");
Review Comment:
From the code point of view, this is a single resource, so it should not be changed directly like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org