You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2004/06/11 04:52:49 UTC
[apreq-2] LockFile on Win32
The current cvs contains a LockFile directive within
env/t/conf/extra.conf.in which isn't available on
Win32 (it's available in leader, perchild, prefork,
threadpool, and worker). This patch:
=====================================================
Index: env/t/conf/extra.conf.in
===================================================================
RCS file: /home/cvs/httpd-apreq-2/env/t/conf/extra.conf.in,v
retrieving revision 1.4
diff -u -r1.4 extra.conf.in
--- env/t/conf/extra.conf.in 10 Jun 2004 20:51:33 -0000 1.4
+++ env/t/conf/extra.conf.in 11 Jun 2004 02:44:07 -0000
@@ -1,5 +1,7 @@
ScriptAlias /cgi-bin/ "@ServerRoot@/cgi-bin/"
-LockFile @ServerRoot@/logs/accept.lock
+<IfModule !mpm_winnt.c>
+ LockFile @ServerRoot@/logs/accept.lock
+</IfModule>
<Directory "@ServerRoot@/cgi-bin">
AllowOverride None
=======================================================
fixes it for Win32, but might there be others for which
LockFile should be skipped?
--
best regards,
randy
Re: [apreq-2] LockFile on Win32
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:
> The current cvs contains a LockFile directive within
> env/t/conf/extra.conf.in which isn't available on
> Win32 (it's available in leader, perchild, prefork,
> threadpool, and worker). This patch:
> =====================================================
> Index: env/t/conf/extra.conf.in
> ===================================================================
> RCS file: /home/cvs/httpd-apreq-2/env/t/conf/extra.conf.in,v
> retrieving revision 1.4
> diff -u -r1.4 extra.conf.in
> --- env/t/conf/extra.conf.in 10 Jun 2004 20:51:33 -0000 1.4
> +++ env/t/conf/extra.conf.in 11 Jun 2004 02:44:07 -0000
> @@ -1,5 +1,7 @@
> ScriptAlias /cgi-bin/ "@ServerRoot@/cgi-bin/"
> -LockFile @ServerRoot@/logs/accept.lock
> +<IfModule !mpm_winnt.c>
> + LockFile @ServerRoot@/logs/accept.lock
> +</IfModule>
>
> <Directory "@ServerRoot@/cgi-bin">
> AllowOverride None
> =======================================================
> fixes it for Win32, but might there be others for which
> LockFile should be skipped?
Not sure, but the patch is certainly an improvement, so +1.
Please commit, and be sure to patch glue/perl/t/conf/extra.cong.in
also.
--
Joe Schaefer