You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 16:49:01 UTC
[GitHub] [spark] kiszk commented on issue #27507: [SPARK-24884][SQL] Support
regexp function regexp_extract_all
kiszk commented on issue #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all
URL: https://github.com/apache/spark/pull/27507#issuecomment-585301466
I have a high-level question. Do we have huge advantage to generate Java code?
One advantage is to store the result of `Pattern.compile()` into each global variable for caching while the non-generated code shares one variable for cache.
On the other hand, the size of the result is not small. Which trade-off do we select? Space or performance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org