You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/13 15:57:48 UTC
[GitHub] [doris] zhannngchen opened a new pull request, #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
zhannngchen opened a new pull request, #15058:
URL: https://github.com/apache/doris/pull/15058
# Proposed changes
Issue Number: close #xxx
## Problem summary
In the following case, data inconsistency would happen between multiple replicas
1. current delta writer only writes a few lines of data (which meas the `write()` method only called once)
2. writer failed when `init()`(which is called at the fist time we call `write()`), and current tablet is recorded in `_broken_tablets`
3. delta writer closed, and in the `close()` method, delta writer found it's not inited, treat such case as an empty load, it will try to init again, which would create an empty rowset.
4. tablet sink received the error report in rpc response, marked the replica as failed, but since the quorum replicas are succeed, so the following load commit operation will succeed.
5. FE send publish version task to each be, the one with empty rowset will publish version successfully.
6. We got 2 replica with data and 1 empty replica.
some related logs:
```
1810937_06.log:I1213 11:20:41.679987 308893 engine_publish_version_task.cpp:230] publish version successfully on tablet, table_id=1810887, tablet=1810937.41350314.9c4623d5c51c0ea5-88d29156b64b668a, transaction_id=3922018, version=27011, num_rows=6, res=OK
1810937_09.log:I1213 11:20:39.680902 44527 engine_publish_version_task.cpp:230] publish version successfully on tablet, table_id=1810887, tablet=1810937.41350314.744d1ca1d02c5584-33f949fb17d7f6b0, transaction_id=3922018, version=27011, num_rows=0, res=OK
1810937_199.log:I1213 11:20:41.678467 181209 engine_publish_version_task.cpp:230] publish version successfully on tablet, table_id=1810887, tablet=1810937.41350314.334bf755ba8a4c32-c9ab5db5baa7599c, transaction_id=3922018, version=27011, num_rows=6, res=OK
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
8. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
9. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
10. Does it need to update dependencies:
- [ ] Yes
- [ ] No
11. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1348918218
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1352614620
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1354103971
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15058:
URL: https://github.com/apache/doris/pull/15058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1350483648
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1349061384
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.13 seconds
load time: 435 seconds
storage size: 17123356887 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221213165700_clickbench_pr_62889.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1351649696
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1350248658
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1351044862
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1354555370
@dataroaring can you help to review and merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1352501063
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1352516209
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1352782008
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15058: [fix](load) delta writer init failed might cause data inconsistency between multiple replicas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15058:
URL: https://github.com/apache/doris/pull/15058#issuecomment-1348887519
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org