You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Zhangshoukui (via GitHub)" <gi...@apache.org> on 2024/08/08 02:20:43 UTC
[PR] Some minor fixes [nuttx]
Zhangshoukui opened a new pull request, #12863:
URL: https://github.com/apache/nuttx/pull/12863
## Summary
1. Fix the location of tmpfs pwrite write
2. Fixed some code check warnings
## Impact
tmpfs
## Testing
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the location of tmpfs pwrite write and Fixed some code check warnings [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12863:
URL: https://github.com/apache/nuttx/pull/12863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Some minor fixes [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #12863:
URL: https://github.com/apache/nuttx/pull/12863#issuecomment-2274920489
@Zhangshoukui please remove Change-Id from commit message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Some minor fixes [nuttx]
Posted by "Zhangshoukui (via GitHub)" <gi...@apache.org>.
Zhangshoukui commented on code in PR #12863:
URL: https://github.com/apache/nuttx/pull/12863#discussion_r1708711795
##########
fs/tmpfs/fs_tmpfs.c:
##########
@@ -1605,7 +1605,15 @@ static ssize_t tmpfs_write(FAR struct file *filep, FAR const char *buffer,
/* Handle attempts to write beyond the end of the file */
- startpos = filep->f_pos;
+ if ((filep->f_oflags & O_APPEND) == O_APPEND)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Some minor fixes [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12863:
URL: https://github.com/apache/nuttx/pull/12863#discussion_r1708617983
##########
fs/tmpfs/fs_tmpfs.c:
##########
@@ -1605,7 +1605,15 @@ static ssize_t tmpfs_write(FAR struct file *filep, FAR const char *buffer,
/* Handle attempts to write beyond the end of the file */
- startpos = filep->f_pos;
+ if ((filep->f_oflags & O_APPEND) == O_APPEND)
Review Comment:
```suggestion
if ((filep->f_oflags & O_APPEND) != 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Some minor fixes [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12863:
URL: https://github.com/apache/nuttx/pull/12863#discussion_r1708726064
##########
fs/tmpfs/fs_tmpfs.c:
##########
@@ -1605,7 +1605,15 @@ static ssize_t tmpfs_write(FAR struct file *filep, FAR const char *buffer,
/* Handle attempts to write beyond the end of the file */
- startpos = filep->f_pos;
+ if ((filep->f_oflags & O_APPEND) == O_APPEND)
Review Comment:
Thanks, check 0 is faster than check constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org