You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/05/10 07:09:47 UTC

Review Request 59131: Added an IPv6 address storage to UPID.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
-------

`libprocess` pids can now hold a v6 address along with a v4 address.


Diffs
-----

  3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 


Diff: https://reviews.apache.org/r/59131/diff/1/


Testing
-------

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/#review179835
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Hindman


On July 6, 2017, 11:31 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59131/
> -----------------------------------------------------------
> 
> (Updated July 6, 2017, 11:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
>     https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an IPv6 address storage to UPID.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid.hpp b0c47ff562c5dfa019f6b392ff269f88a72d40d2 
>   3rdparty/libprocess/src/pid.cpp 5191a9dbf478acfa758c602748cafdb296182953 
> 
> 
> Diff: https://reviews.apache.org/r/59131/diff/6/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

(Updated July 6, 2017, 11:31 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed BenH's comments.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
-------

Added an IPv6 address storage to UPID.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid.hpp b0c47ff562c5dfa019f6b392ff269f88a72d40d2 
  3rdparty/libprocess/src/pid.cpp 5191a9dbf478acfa758c602748cafdb296182953 


Diff: https://reviews.apache.org/r/59131/diff/6/

Changes: https://reviews.apache.org/r/59131/diff/5-6/


Testing
-------

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/#review179727
-----------------------------------------------------------




3rdparty/libprocess/include/process/pid.hpp
Lines 97 (patched)
<https://reviews.apache.org/r/59131/#comment254564>

    ```
    struct
    {
    #ifdef __WINDOWS__
      Option<network::unix::Address> unix;
    #endif // __WINDOWS__
      Option<network::inet4::Address> v4;
      Option<network::inet6::Address> v6;
    } address;
    ```
    
    ?


- Benjamin Hindman


On June 29, 2017, 11:23 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59131/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 11:23 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
>     https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an IPv6 address storage to UPID.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 
>   3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 
> 
> 
> Diff: https://reviews.apache.org/r/59131/diff/5/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
-------

Added an IPv6 address storage to UPID.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 


Diff: https://reviews.apache.org/r/59131/diff/5/

Changes: https://reviews.apache.org/r/59131/diff/4-5/


Testing
-------

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

(Updated June 29, 2017, 11:17 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased and fixed some missing copy operations for the new `address6` field.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
-------

Added an IPv6 address storage to UPID.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 


Diff: https://reviews.apache.org/r/59131/diff/4/

Changes: https://reviews.apache.org/r/59131/diff/3-4/


Testing
-------

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

(Updated June 16, 2017, 4:38 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description (updated)
-------

Added an IPv6 address storage to UPID.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 


Diff: https://reviews.apache.org/r/59131/diff/3/

Changes: https://reviews.apache.org/r/59131/diff/2-3/


Testing
-------

make check.


Thanks,

Avinash sridharan

Re: Review Request 59131: Added an IPv6 address storage to UPID.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/
-----------------------------------------------------------

(Updated May 31, 2017, 6:40 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
-------

`libprocess` pids can now hold a v6 address along with a v4 address.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a 
  3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 


Diff: https://reviews.apache.org/r/59131/diff/2/

Changes: https://reviews.apache.org/r/59131/diff/1-2/


Testing
-------

make check.


Thanks,

Avinash sridharan