You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/08/01 07:18:40 UTC
Review Request 71222: Added a test
`VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71222/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9893
https://issues.apache.org/jira/browse/MESOS-9893
Repository: mesos
Description
-------
Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
Diffs
-----
src/tests/containerizer/volume_secret_isolator_tests.cpp b6c43c3c3fcc61cd1bd03725cde78e58bcff801e
Diff: https://reviews.apache.org/r/71222/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71222: Added a test
`VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71222/#review217038
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71201, 71221, 71222]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 1, 2019, 7:18 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71222/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 7:18 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9893
> https://issues.apache.org/jira/browse/MESOS-9893
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_secret_isolator_tests.cpp b6c43c3c3fcc61cd1bd03725cde78e58bcff801e
>
>
> Diff: https://reviews.apache.org/r/71222/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71222: Added a test
`VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71222/#review217227
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 1, 2019, 12:18 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71222/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 12:18 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9893
> https://issues.apache.org/jira/browse/MESOS-9893
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_secret_isolator_tests.cpp b6c43c3c3fcc61cd1bd03725cde78e58bcff801e
>
>
> Diff: https://reviews.apache.org/r/71222/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>