[GitHub] [pulsar] lhotari commented on a diff in pull request #15640: [Autorecovery] Default reppDnsResolverClass to ZkBookieRackAffinityMapping

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #15640:
URL: https://github.com/apache/pulsar/pull/15640#discussion_r940880414


##########
conf/bookkeeper.conf:
##########
@@ -277,6 +277,13 @@ useV2WireProtocol=true
 #
 # ensemblePlacementPolicy=org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicy
 
+# The DNS resolver class used for resolving network locations for bookies. The setting is used

Review Comment:
   I wonder if it should be mentioned that this setting would be used for the bookie client used in bookies for autorecovery and compaction? 
   
   It would also be worth mentioning that this setting should match the setting for bookie clients in broker. In broker.conf, ZkBookieRackAffinityMapping will be used when `bookkeeperClientRackawarePolicyEnabled=true`. This is mentioned in this comment: https://github.com/apache/pulsar/issues/151#issuecomment-268802489
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org