You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/11/25 06:19:58 UTC

[GitHub] [hbase] Apache9 commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

Apache9 commented on pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#issuecomment-733493026


   These classes are all implementation class, so in general I do not think it is a good idea to make them public to others.
   
   I did a simple search on https://github.com/apache/phoenix/pull/978, seems the requirement here is to create a Tag? Could we introduce something like a Tag builder and make it IA.LimitedPrivate, instead of directly expose these implementation classes?
   
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org