You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtadepalli (via GitHub)" <gi...@apache.org> on 2023/03/04 02:07:31 UTC
[GitHub] [arrow-adbc] rtadepalli opened a new pull request, #489: Close allocator on JDBC connection close
rtadepalli opened a new pull request, #489:
URL: https://github.com/apache/arrow-adbc/pull/489
Call `allocator.close()` when JDBC connection is being closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #489: fix(java): close allocator on JDBC connection close
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #489:
URL: https://github.com/apache/arrow-adbc/pull/489#discussion_r1126368364
##########
java/driver/jdbc/src/main/java/org/apache/arrow/adbc/driver/jdbc/JdbcConnection.java:
##########
@@ -254,6 +254,7 @@ public void setIsolationLevel(IsolationLevel level) throws AdbcException {
@Override
public void close() throws Exception {
connection.close();
+ allocator.close();
Review Comment:
Can we use AutoCloseables here so that an exception raised by one of the close() methods won't affect the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] rtadepalli closed pull request #489: fix(java/driver/jdbc): close allocator on JDBC connection close
Posted by "rtadepalli (via GitHub)" <gi...@apache.org>.
rtadepalli closed pull request #489: fix(java/driver/jdbc): close allocator on JDBC connection close
URL: https://github.com/apache/arrow-adbc/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] github-actions[bot] commented on pull request #489: Close allocator on JDBC connection close
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #489:
URL: https://github.com/apache/arrow-adbc/pull/489#issuecomment-1454335772
:warning: Please follow the [Conventional Commits format in CONTRIBUTING.md](https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md) for PR titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] rtadepalli commented on pull request #489: fix(java/driver/jdbc): close allocator on JDBC connection close
Posted by "rtadepalli (via GitHub)" <gi...@apache.org>.
rtadepalli commented on PR #489:
URL: https://github.com/apache/arrow-adbc/pull/489#issuecomment-1488615054
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #489: fix(java/driver/jdbc): close allocator on JDBC connection close
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #489:
URL: https://github.com/apache/arrow-adbc/pull/489#issuecomment-1476386970
I ended up addressing this in #533 since it was needed to fix the issue there, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org