You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/09 01:42:57 UTC
[GitHub] [rocketmq] ltamber commented on a diff in pull request #5244: [ISSUE #5243] Add acl support to TimerProducer/TimerConsumer
ltamber commented on code in PR #5244:
URL: https://github.com/apache/rocketmq/pull/5244#discussion_r990717698
##########
example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java:
##########
@@ -151,6 +166,30 @@ private Options buildCommandlineOptions(Options options) {
opt.setRequired(false);
options.addOption(opt);
+ opt = new Option("w", "threadCount", true, "Thread count, Default: 20");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("m", "msgTraceEnable", true, "Message Trace Enable, Default: false");
Review Comment:
how about use a no argument option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [rocketmq] ltamber commented on a diff in pull request #5244: [ISSUE #5243] Add acl support to TimerProducer/TimerConsumer
Posted by "zhiliatox@163.com" <zh...@163.com>.
Good suggestion, but to keep consistent wist other code, I don't do any change here
zhiliatox@163.com
From: GitBox
Date: 2022-10-09 09:42
To: dev
Subject: [GitHub] [rocketmq] ltamber commented on a diff in pull request #5244: [ISSUE #5243] Add acl support to TimerProducer/TimerConsumer
ltamber commented on code in PR #5244:
URL: https://github.com/apache/rocketmq/pull/5244#discussion_r990717698
##########
example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java:
##########
@@ -151,6 +166,30 @@ private Options buildCommandlineOptions(Options options) {
opt.setRequired(false);
options.addOption(opt);
+ opt = new Option("w", "threadCount", true, "Thread count, Default: 20");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("m", "msgTraceEnable", true, "Message Trace Enable, Default: false");
Review Comment:
how about use a no argument option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org