You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/16 23:53:31 UTC
[GitHub] [tvm] mdw-octoml opened a new pull request #7869: Update ICHECK error message with link to documentation page.
mdw-octoml opened a new pull request #7869:
URL: https://github.com/apache/tvm/pull/7869
This PR updates the error message emitted by ICHECK failures to point to a documentation page, which we can update over time with more information on common failure cases and hints on how to resolve them. Welcome comments on the exact wording and the content of the documentation page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7869:
URL: https://github.com/apache/tvm/pull/7869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-824974829
@tqchen @jroesch Looks like this is good to land
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-824425907
I think I have resolved the merge issue, this should be good to land once CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822951165
I feel like that should be a separate PR. If you can tell me where to make
the change, I will, but in general one should avoid mixing unrelated
changes in a single PR.
On Mon, Apr 19, 2021 at 6:08 PM Tristan Konolige ***@***.***>
wrote:
> Yeah, try bumping it to something larger.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/7869#issuecomment-822895743>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APEJO5FMUWVSGG4T46LSSCLTJTH2XANCNFSM43CNTCQQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822723933
I changed it to "What to do when encountering TVM errors" -- WDYT?
On Mon, Apr 19, 2021 at 10:26 AM Tianqi Chen ***@***.***>
wrote:
> Makes sense. Wonders if we can have a better tile. Since it is under how
> to section, perhaps Handle Errors. The flaky error is known in #7870
> <https://github.com/apache/tvm/issues/7870>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/7869#issuecomment-822642893>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APEJO5BWVGOXDLKNHJE35STTJRRTRANCNFSM43CNTCQQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822857357
@tkonolige, it looks like this PR hit an error in the VM RPC test. Maybe we need to bump up the delay in the test from 2 seconds to a little longer to guarantee stability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822570907
Fixed the lint error.
The existing error handling doc is for TVM developers, not TVM users. (It is also fairly confusing and includes a lot of details that someone simply using TVM would not need to understand.) Rather than try to have a single doc for both audiences, I think it is best to keep the user documentation separate, so it is less confusing. I added a link from the new doc to the developer doc for those who want to understand the details of how errors are generated.
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-824991891
Thanks @mdw-octoml for contributing. Thanks @michalpiszczek @jwfromm for reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822895743
Yeah, try bumping it to something larger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822804456
That sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-821824248
@mdw-octoml please fix the lint error, there is already an error handling doc here, would be great to merge the content with that one https://github.com/apache/tvm/blob/main/docs/contribute/error_handling.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7869: Update ICHECK error message with link to documentation page.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7869:
URL: https://github.com/apache/tvm/pull/7869#issuecomment-822642893
Makes sense. Wonders if we can have a better tile. Since it is under how to section, perhaps `Handle Errors`. The flaky error is known in https://github.com/apache/tvm/issues/7870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org