You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/05/04 23:16:52 UTC
[GitHub] codecov-io commented on issue #3615: Terminate route for invalid
list skip values
codecov-io commented on issue #3615: Terminate route for invalid list skip values
URL: https://github.com/apache/incubator-openwhisk/pull/3615#issuecomment-386757956
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=h1) Report
> Merging [#3615](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6fef5c41756ef174f10c671f1a1a010702839663?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3615 +/- ##
==========================================
+ Coverage 74.4% 74.54% +0.13%
==========================================
Files 125 125
Lines 5951 5975 +24
Branches 384 385 +1
==========================================
+ Hits 4428 4454 +26
+ Misses 1523 1521 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <100%> (+1.26%)` | :arrow_up: |
| [...rc/main/scala/whisk/core/controller/Packages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9QYWNrYWdlcy5zY2FsYQ==) | `89.32% <100%> (+0.43%)` | :arrow_up: |
| [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <100%> (+0.05%)` | :arrow_up: |
| [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <100%> (+4.94%)` | :arrow_up: |
| [...main/scala/whisk/core/entitlement/Collection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvQ29sbGVjdGlvbi5zY2FsYQ==) | `85.71% <100%> (+0.34%)` | :arrow_up: |
| [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `91.28% <87.5%> (+0.18%)` | :arrow_up: |
| [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `80.71% <87.5%> (+0.56%)` | :arrow_up: |
| [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.26% <87.5%> (+0.29%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=footer). Last update [6fef5c4...7d4fc38](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services