[GitHub] benkamphaus commented on a change in pull request #12387: MXNET-873 - Bring Clojure Package Inline with New DataDesc and Layout in Scala Package

[GitBox <gi...@apache.org>]

benkamphaus commented on a change in pull request #12387: MXNET-873 - Bring Clojure Package Inline with New DataDesc and Layout in Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/12387#discussion_r214379325
 
 

 ##########
 File path: contrib/clojure-package/src/org/apache/clojure_mxnet/io.clj
 ##########
 @@ -213,14 +245,24 @@
                last-batch-handle "pad"
                data-name "data"
                label-name "label"}}]
-   (new NDArrayIter
-        (util/vec->indexed-seq data)
-        (if label (util/vec->indexed-seq label) (util/empty-indexed-seq))
-        (int data-batch-size)
-        shuffle
-        last-batch-handle
-        data-name
-        label-name))
+   (let [specify-data-desc? (map? data)]
 
 Review comment:
   nit: is this just in the `let` for a self-documenting name/rationale?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services