[jira] [Commented] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

["Jonathan Eagles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959092#comment-15959092 ] 

Jonathan Eagles commented on TEZ-3684:
--------------------------------------

[~sseth], This patch has a good portion the minor-nit non-essential TEZ-3334 feedback. It was easier to incorporate this feedback before the merge than to keep track of.

> Incorporate first pass non-essential TEZ-3334 pre-merge feedback
> ----------------------------------------------------------------
>
>                 Key: TEZ-3684
>                 URL: https://issues.apache.org/jira/browse/TEZ-3684
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-3684.1.patch
>
>
> Incorporates this feedback from TEZ-3334 https://issues.apache.org/jira/browse/TEZ-3334?focusedCommentId=15950550&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15950550
> - TezContainerLauncherImpl - ByteBuffer portInfo =response.getAllServicesMetaData().get(conf.get(TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID,TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT)); - Could be split into multiple calls, in case there's a possibility of a NPE.
> - TestShuffleHandlerJobs. Parameter name mrrTez - should really be tez*.
> - Variable renames. pendingInputsOfOnePartition is no longer a valid name.
> - InputHost.clearAndGetOnePartition - rename. This is no longer giving back a single partition only.
> - pendingInputsOfOnePartition - name is likely not valid any longer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)