[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6514: Fix traffic_portal audit issues and remove un-needed deps

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514#discussion_r789953950



##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
     "angular-route": "1.8.0",
     "angular-sanitize": "1.8.0",
     "angular-ui-bootstrap": "0.14.3",
-    "bootstrap-sass": "3.3.6",
-    "es5-shim": "4.5.6",
+    "bootstrap-sass": "3.4.1",
+    "es5-shim": "4.6.4",

Review comment:
        Technically `browserify` should be handling this for us anyways so you're probably right, but it's required in `shared-libs.js` which means it could be being used somewhere in the app. Removing that is the kind of change that i think would be better done in a separate PR (probably whatever PR we update angular in since we're out of date a few minor versions). All of the packages I've removed in this PR are not referenced _anywhere_ (aside from the jshint stuff) outside of the package.json.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org