You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/07/30 17:22:45 UTC
[GitHub] [incubator-daffodil] mbeckerle opened a new pull request #403: Tests for textNumberPattern and padding unexpected behaviors.
mbeckerle opened a new pull request #403:
URL: https://github.com/apache/incubator-daffodil/pull/403
Came up in DFDL workgroup email discussions.
The behavior was determined to be working as designed, and conforming to the spec.
This is just adding the tests for good measure here.
Ticket was closed as "not a bug".
DAFFODIL-2378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle merged pull request #403: Tests for textNumberPattern and padding unexpected behaviors.
Posted by GitBox <gi...@apache.org>.
mbeckerle merged pull request #403:
URL: https://github.com/apache/incubator-daffodil/pull/403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #403: Tests for textNumberPattern and padding unexpected behaviors.
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #403:
URL: https://github.com/apache/incubator-daffodil/pull/403#discussion_r464363487
##########
File path: daffodil-test/src/test/resources/org/apache/daffodil/usertests/UserSubmittedTests.tdml
##########
@@ -132,4 +132,55 @@
</tdml:infoset>
</tdml:parserTestCase>
+ <tdml:defineSchema name="dfdlwg1" elementFormDefault="unqualified">
+ <xs:include schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/>
+
+ <dfdl:format ref="ex:GeneralFormat" lengthKind="delimited"/>
+
+ <!-- wrong way to get zero-extended 9-digit numbers -->
+ <xs:element name="r" dfdl:textNumberPattern="#0" type="ex:numeric9_custom1"/>
+
+ <!-- right way to get zero-extended 9-digit numbers -->
+ <xs:element name="r2" dfdl:textNumberPattern="#00000000" type="ex:numeric9_custom1"/>
+
+ <xs:simpleType name="numeric9_custom1"
+ dfdl:textOutputMinLength="9"
+ dfdl:textPadKind="padChar"
+ dfdl:textTrimKind="padChar"
Review comment:
Odd indentation here. Mixture of tabs and spaces maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org