You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/11 12:55:15 UTC
[GitHub] [arrow-datafusion] alamb commented on pull request #5246: [SQLLogicTest] Remove schema check
alamb commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426760371
> I, unfortunately, cannot tell if this check is always needed. It was added in https://github.com/apache/arrow-datafusion/pull/4578/files#diff-4d4a58673140be1acf7a04b9aa71a29f106ebb75a256553e2a9ff13d9a3856f4. @alamb Could you please take a look.
We have seen this in the past where schemas differ only in nullability (hence `equivalent_names_and_types`)
It might be safer to change the check to verify the fields name and types (rather than `schema == schema`). What do you think @comphead and @melgenek ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org