You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "tao12345666333 (via GitHub)" <gi...@apache.org> on 2023/08/29 08:40:08 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request, #1942: chore: add Gallardot for deps reviewer
tao12345666333 opened a new pull request, #1942:
URL: https://github.com/apache/apisix-ingress-controller/pull/1942
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [ ] Refactor
- [x] Chore
- [ ] CI/CD or Tests
### What this PR does / why we need it:
@Gallardot helped us review a lot of PRs, I think we can add him as a default reviewer.
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1942: chore: add Gallardot for deps reviewer
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1942:
URL: https://github.com/apache/apisix-ingress-controller/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1942: chore: add Gallardot for deps reviewer
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1942:
URL: https://github.com/apache/apisix-ingress-controller/pull/1942#issuecomment-1697020144
## [Codecov](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1942](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1942?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (acbdb80) into [master](https://app.codecov.io/gh/apache/apisix-ingress-controller/commit/e0a2b17bc6d6a5010f3ad2c36a2cae77f4f38d3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0a2b17) will **not change** coverage.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head acbdb80 differs from pull request most recent head 39a93b2. Consider uploading reports for the commit 39a93b2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1942 +/- ##
=======================================
Coverage 40.47% 40.47%
=======================================
Files 92 92
Lines 7100 7100
=======================================
Hits 2874 2874
Misses 3842 3842
Partials 384 384
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1942: chore: add Gallardot for deps reviewer
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1942:
URL: https://github.com/apache/apisix-ingress-controller/pull/1942#issuecomment-1697015035
wait for @Gallardot 's response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org