You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/04 02:56:28 UTC

[GitHub] [spark] Yikun opened a new pull request, #37402: [SPARK-39974][INFRA] Create separate static image tag for infra cache

Yikun opened a new pull request, #37402:
URL: https://github.com/apache/spark/pull/37402

   ### What changes were proposed in this pull request?
   Create separate static image tag for infra cache
   
   
   ### Why are the changes needed?
   Currently, we put the **static image** and **cache** together in same tag like [`ghcr.io/apache/spark/apache-spark-github-action-image-cache:master`](https://github.com/apache/spark/pkgs/container/spark%2Fapache-spark-github-action-image-cache/versions).
   
   Cache and static image occupy separate image hash and same image tags. this bring some problem in below cases:
   - **Debug job with static docker images**, they have to find hash. If use cache directly, will raise something like:
   ```
   yikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master
   Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master' locally
   master: Pulling from yikun/apache-spark-github-action-image-cache
   docker: no matching manifest for linux/amd64 in the manifest list entries.
   ```
   
   - **Use static image in CI**, such as for some reason we want to switch static image temporarily.
   - **Easy to see history for last cache**, such as system deps/lib.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   - Local test: https://github.com/Yikun/spark/pull/144, and statich image tag push [passed](https://github.com/Yikun/spark/runs/7664266955?check_suite_focus=true#step:6:212)
   - Run static image:
   ```
   root@yikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master-static
   Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master-static' locally
   master-static: Pulling from yikun/apache-spark-github-action-image-cache
   Digest: sha256:5198fd8111c925b7c92d04427268bcb0e5574bb72cef09808076595f3372bf7b
   Status: Downloaded newer image for ghcr.io/yikun/apache-spark-github-action-image-cache:master-static
   root@3550e09e0e93:/# exit
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun commented on pull request #37402: [SPARK-39974][INFRA] Create separate static image tag for infra cache

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37402:
URL: https://github.com/apache/spark/pull/37402#issuecomment-1204807889

   Ready to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #37402: [SPARK-39974][INFRA] Create separate static image tag for infra cache

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37402: [SPARK-39974][INFRA] Create separate static image tag for infra cache
URL: https://github.com/apache/spark/pull/37402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #37402: [SPARK-39974][INFRA] Create separate static image tag for infra cache

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37402:
URL: https://github.com/apache/spark/pull/37402#issuecomment-1205889526

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org