[jira] Created: (MYFACES-1771) Design issue: We are having a hard time adding attributes to Tomahawk/Myfaces Implementations

["Raghunandan Sapre (JIRA)" <de...@myfaces.apache.org>]

Design issue: We are having a hard time adding attributes to Tomahawk/Myfaces Implementations
---------------------------------------------------------------------------------------------

                 Key: MYFACES-1771
                 URL: https://issues.apache.org/jira/browse/MYFACES-1771
             Project: MyFaces Core
          Issue Type: Bug
          Components: General
    Affects Versions: 1.1.4
         Environment: Tomahawk 1.1.3, 1.1.4, Myfcaes 1.1.4
            Reporter: Raghunandan Sapre


This is about  wrong practise of calling startElement()  and endElement() inside encodeBegin(). 
Is this a major design flaw? 
I think startElement() should be called inside encodeBegin()
and endElement() should always be called inside encodeEnd()? 
This gives people a chance to add new attributes by overriding encodeBegin() or encodeEnd().
I think the JSF spec should specify this along with saying that (javaDoc for ResponseWriter)
"ResponseWriter class does not allow to call writeAttribute() once endElement() is called".
We are not able to add new attributes to Tomahawk/Myfaces Implementations unless we modify the source code.
Thanks
Raghu

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.