[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #7038: to #7001: delete certain edge in processDefinition

[GitBox <gi...@apache.org>]

JinyLeeChina commented on a change in pull request #7038:
URL: https://github.com/apache/dolphinscheduler/pull/7038#discussion_r758195871



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessTaskRelationController.java
##########
@@ -253,4 +254,28 @@ public Result queryDownstreamRelation(@ApiIgnore @RequestAttribute(value = Const
                                           @PathVariable("taskCode") long taskCode) {
         return returnDataList(processTaskRelationService.queryDownstreamRelation(loginUser, projectCode, taskCode));
     }
+
+    /**
+     * delete edge
+     *
+     * @param loginUser             login user
+     * @param projectCode           project code
+     * @param processTaskRelationId process task relation id
+     * @return delete result code
+     */
+    @ApiOperation(value = "deleteEdge", notes = "DELETE_EDGE_NOTES")
+    @ApiImplicitParams({
+        @ApiImplicitParam(name = "projectCode", value = "PROJECT_CODE", required = true, type = "Long"),
+        @ApiImplicitParam(name = "processTaskRelationId", value = "PROCESS_TASK_RELATION_ID", required = true, dataType = "Int", example = "100")
+    })
+    @DeleteMapping(value = "/{id}")

Review comment:
       We cannot use ID, which is meaningless in relation. When the workflow regenerates the version, the ID here will change and the interaction with external systems is not friendly enough




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org