You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:48:22 UTC
[GitHub] [dubbo] jefftlin opened a new pull request, #10377: Add test case about module dubbo-rpc-rocketmq jefftlin committed 2 minutes ago
jefftlin opened a new pull request, #10377:
URL: https://github.com/apache/dubbo/pull/10377
## What is the purpose of the change
Add test case
Update pom
Rename commonconstants
## Brief changelog
## Verifying this change
Run method testRocketmqProtocolServer
Run method testExport
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #10377: Add test case about module dubbo-rpc-rocketmq jefftlin committed 2 minutes ago
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on PR #10377:
URL: https://github.com/apache/dubbo/pull/10377#issuecomment-1197611813
Please submit to dubbo-spi-extensions repo. Do not merge into main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed pull request #10377: Add test case about module dubbo-rpc-rocketmq jefftlin committed 2 minutes ago
Posted by GitBox <gi...@apache.org>.
chickenlj closed pull request #10377: Add test case about module dubbo-rpc-rocketmq jefftlin committed 2 minutes ago
URL: https://github.com/apache/dubbo/pull/10377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on pull request #10377: Add test case about module dubbo-rpc-rocketmq jefftlin committed 2 minutes ago
Posted by GitBox <gi...@apache.org>.
chickenlj commented on PR #10377:
URL: https://github.com/apache/dubbo/pull/10377#issuecomment-1199028001
check https://github.com/apache/dubbo-spi-extensions/pull/130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org