You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 03:13:37 UTC
[jira] [Created] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
-------------------------------------------------------------------------
Key: HBASE-5591
URL: https://issues.apache.org/jira/browse/HBASE-5591
Project: HBase
Issue Type: Improvement
Reporter: Scott Chen
Assignee: Scott Chen
Priority: Trivial
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467081#comment-13467081 ]
Scott Chen commented on HBASE-5591:
-----------------------------------
Yes, permission granted.
I couldn't find the UI for granting the permission.
Does this statement in the comment count?
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch, ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467087#comment-13467087 ]
stack commented on HBASE-5591:
------------------------------
Thank you Scott.
No check box any more. If you don't want to include it, you say so in a comment (Might be easier on you fellas with your auto-posting phabricator).
Thanks for perm.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch, ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467079#comment-13467079 ]
Hadoop QA commented on HBASE-5591:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12547256/ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2978//console
This message is automatically generated.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch, ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236444#comment-13236444 ]
Phabricator commented on HBASE-5591:
------------------------------------
sc has commented on the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:611 Sorry for the trouble. Thanks for bearing with me :)
REVISION DETAIL
https://reviews.facebook.net/D2355
BRANCH
getbytes
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465054#comment-13465054 ]
stack commented on HBASE-5591:
------------------------------
This was committed to trunk a while back but will leave it open until Scott grants Apache permission.
[~schen] Would you mind granting permission for this already committed patch else we'll have to remove it from trunk. Thanks boss.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5591:
------------------------------
Attachment: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch, ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272654#comment-13272654 ]
Phabricator commented on HBASE-5591:
------------------------------------
sc has closed the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
REVISION DETAIL
https://reviews.facebook.net/D2355
To: tedyu, dhruba, JIRA, sc
Cc: stack
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230840#comment-13230840 ]
Phabricator commented on HBASE-5591:
------------------------------------
tedyu has accepted the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
If tests pass.
REVISION DETAIL
https://reviews.facebook.net/D2355
BRANCH
getbytes
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236366#comment-13236366 ]
Hudson commented on HBASE-5591:
-------------------------------
Integrated in HBase-TRUNK-security #146 (See [https://builds.apache.org/job/HBase-TRUNK-security/146/])
HBASE-5591 ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes() (Scott Chen) (Revision 1304047)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5591:
------------------------------
Status: Patch Available (was: Open)
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5591:
------------------------------
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Integrated to trunk.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5591:
-------------------------------
Attachment: HBASE-5591.D2355.1.patch
sc requested code review of "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
Reviewers: tedyu, dhruba, JIRA
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Remove the redundant method.
Task ID: #
Blame Rev:
TEST PLAN
Revert Plan:
Tags:
REVISION DETAIL
https://reviews.facebook.net/D2355
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5229/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236027#comment-13236027 ]
Phabricator commented on HBASE-5591:
------------------------------------
sc has commented on the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:611 It was added by me actually.
Because I checked Bytes.toBytes(ByteBuffer bb) and found that it's different from this one.
But this one is the same as Bytes.getBytes(ByteBuffer bb).
These names are really confusing.
REVISION DETAIL
https://reviews.facebook.net/D2355
BRANCH
getbytes
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236380#comment-13236380 ]
Phabricator commented on HBASE-5591:
------------------------------------
stack has commented on the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:611 Funny. If it was added by you, then I'd say its your prerogative to remove it! Good stuff.
REVISION DETAIL
https://reviews.facebook.net/D2355
BRANCH
getbytes
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237202#comment-13237202 ]
Hudson commented on HBASE-5591:
-------------------------------
Integrated in HBase-TRUNK #2693 (See [https://builds.apache.org/job/HBase-TRUNK/2693/])
HBASE-5591 ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes() (Scott Chen) (Revision 1304047)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5591:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: ASF.LICENSE.GRANTED--HBASE-5591.D2355.1.patch, ASF.LICENSE.NOT.GRANTED--HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235999#comment-13235999 ]
Hadoop QA commented on HBASE-5591:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518598/HBASE-5591.D2355.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1261//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1261//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1261//console
This message is automatically generated.
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5591)
ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236007#comment-13236007 ]
Phabricator commented on HBASE-5591:
------------------------------------
stack has commented on the revision "HBASE-5591 [jira] ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()".
Otherwise patch looks good.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:611 Why do you think this comment is here Scott? Its ominous lookinh.
REVISION DETAIL
https://reviews.facebook.net/D2355
BRANCH
getbytes
> ThiftServerRunner.HBaseHandler.toBytes() is identical to Bytes.getBytes()
> -------------------------------------------------------------------------
>
> Key: HBASE-5591
> URL: https://issues.apache.org/jira/browse/HBASE-5591
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Trivial
> Attachments: HBASE-5591.D2355.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira