[GitHub] [airflow] enima2684 commented on a change in pull request #17474: Add support for configs, secrets, networks and replicas for DockerSwarmOperator

[GitBox <gi...@apache.org>]

enima2684 commented on a change in pull request #17474:
URL: https://github.com/apache/airflow/pull/17474#discussion_r684980438



##########
File path: airflow/providers/docker/operators/docker_swarm.py
##########
@@ -121,12 +153,16 @@ def _run_service(self) -> None:
                     env=self.environment,
                     user=self.user,
                     tty=self.tty,
+                    configs=self.configs,
+                    secrets=self.secrets,
                 ),
                 restart_policy=types.RestartPolicy(condition='none'),
                 resources=types.Resources(mem_limit=self.mem_limit),
+                networks=self.networks,
             ),
             name=f'airflow-{get_random_string()}',
             labels={'name': f'airflow__{self.dag_id}__{self.task_id}'},
+            mode=types.ServiceMode(mode=self.mode, replicas=self.replicas),

Review comment:
       Thanks @uranusjr for your review.
   I did not get your remark. Can you please elaborate ?
   In all cases, I followed the signature of the function `create_service` as defined on the docker sdk for python : 
   https://docker-py.readthedocs.io/en/stable/api.html#module-docker.api.service




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org