You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2020/12/10 20:01:09 UTC
Re: Review Request 73022: ATLAS-4032 Filter group option in the Admin
Audit tab is not giving the expected output
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/#review222320
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
Lines 192 (patched)
<https://reviews.apache.org/r/73022/#comment311378>
include invalid attribute name in error code message
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
Lines 194 (patched)
<https://reviews.apache.org/r/73022/#comment311380>
include invalid operator in error code message
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
Lines 196 (patched)
<https://reviews.apache.org/r/73022/#comment311379>
include invalid attribute value in error code message
- Sarath Subramanian
On Nov. 18, 2020, 8:06 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73022/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2020, 8:06 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4032
> https://issues.apache.org/jira/browse/ATLAS-4032
>
>
> Repository: atlas
>
>
> Description
> -------
>
> In the existing code we are not including the Inner Criterias of the Filter.
>
> Also the Condition of the Outer filter was getting applied to the Inner Filters groups.
>
> In this patch, code refactoring is done. The code which populate the Filter Criteria is now removed.
>
> Instead of doing it from Server end, This patch keeps the Filter Criteria in the same format which UI has sent.
>
> Additionally this patch provides validation for the Filter Criteria 1.Attribute Name 2. Attribute Value and 3.Operator
> This validation goes until the last level of the Inner Filter Criterias.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa9
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java d843204
>
>
> Diff: https://reviews.apache.org/r/73022/diff/1/
>
>
> Testing
> -------
>
> Manual testing is done for the scenarios where Filter Groups are included.
>
> Earlier it was not giving expected search result.
>
> With this patch we can get the expected result in the Admin Audit Search.
>
> PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/203/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 73022: ATLAS-4032 Filter group option in the Admin
Audit tab is not giving the expected output
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 192 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line206>
> >
> > include invalid attribute name in error code message
Hi Sarath, this error is thrown when the name of attribute is not found (null)
> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 194 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line208>
> >
> > include invalid operator in error code message
Hi Sarath, this error is thrown when the operator of attribute is not found (null)
> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 196 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line210>
> >
> > include invalid attribute value in error code message
Hi Sarath, this error is thrown when the value of attribute is not found (null)
- Mandar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/#review222320
-----------------------------------------------------------
On Nov. 19, 2020, 4:06 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73022/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2020, 4:06 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4032
> https://issues.apache.org/jira/browse/ATLAS-4032
>
>
> Repository: atlas
>
>
> Description
> -------
>
> In the existing code we are not including the Inner Criterias of the Filter.
>
> Also the Condition of the Outer filter was getting applied to the Inner Filters groups.
>
> In this patch, code refactoring is done. The code which populate the Filter Criteria is now removed.
>
> Instead of doing it from Server end, This patch keeps the Filter Criteria in the same format which UI has sent.
>
> Additionally this patch provides validation for the Filter Criteria 1.Attribute Name 2. Attribute Value and 3.Operator
> This validation goes until the last level of the Inner Filter Criterias.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa9
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java d843204
>
>
> Diff: https://reviews.apache.org/r/73022/diff/1/
>
>
> Testing
> -------
>
> Manual testing is done for the scenarios where Filter Groups are included.
>
> Earlier it was not giving expected search result.
>
> With this patch we can get the expected result in the Admin Audit Search.
>
> PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/203/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>