You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 07:53:21 UTC
[GitHub] [incubator-superset] villebro commented on a change in pull request
#8960: fix: shut off unneeded endpoints
villebro commented on a change in pull request #8960: fix: shut off unneeded endpoints
URL: https://github.com/apache/incubator-superset/pull/8960#discussion_r369410454
##########
File path: superset/app.py
##########
@@ -324,23 +323,11 @@ def init_views(self) -> None:
category_label=__("Sources"),
category_icon="fa-wrench",
)
- appbuilder.add_link(
- "Tables",
- label=__("Tables"),
- href="/tablemodelview/list/?_flt_1_is_sqllab_view=y",
- icon="fa-table",
- category="Sources",
- category_label=__("Sources"),
- category_icon="fa-table",
- )
#
# Conditionally setup log views
#
- if (
- not self.config["FAB_ADD_SECURITY_VIEWS"] is False
- or self.config["SUPERSET_LOG_VIEW"] is False
- ):
+ if self.config["FAB_ADD_SECURITY_VIEWS"] and self.config["SUPERSET_LOG_VIEW"]:
Review comment:
I think the original slightly weird double negative notation is a consequence of originally having assumed that config parameters weren't always set. This has changed with the adoption of square brackets when retrieving config params over `get()`. I think it makes sense to think critically of what the behavour should be instead of persisting the existing logic as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org