You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "David E. Jones (JIRA)" <ji...@apache.org> on 2006/07/06 04:32:29 UTC
[jira] Created: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Bug in Commission code (showing in getCommissionForProduct service)
-------------------------------------------------------------------
Key: OFBIZ-80
URL: http://issues.apache.org/jira/browse/OFBIZ-80
Project: The Open For Business Project
Type: Bug
Components: accounting
Versions: SVN trunk
Reporter: David E. Jones
When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
Here are a couple of messages from the log:
143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=all ]
Si Chen closed OFBIZ-80.
------------------------
Resolution: Fixed
Great. Committed r 438976.
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: David E. Jones
> Assigned To: Si Chen
> Attachments: getCommissionForProduct06-08-28.patch
>
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=comments#action_12420136 ]
Si Chen commented on OFBIZ-80:
------------------------------
David,
Is the issue that there are no parties associated with a Digital Good, which is immediately invoiced, paid, and payment applied?
What product can we check this with?
Si
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: The Open For Business Project
> Type: Bug
> Components: accounting
> Versions: SVN trunk
> Reporter: David E. Jones
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=comments#action_12420147 ]
David E. Jones commented on OFBIZ-80:
-------------------------------------
The easiest products to see this with are the Digital and Newsletter Gizmos (GZ-DIG and GZ-NEWS-1MO).
As to why it's happening, I'm not sure... I didn't really trace it down very far.
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: The Open For Business Project
> Type: Bug
> Components: accounting
> Versions: SVN trunk
> Reporter: David E. Jones
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=comments#action_12419390 ]
David E. Jones commented on OFBIZ-80:
-------------------------------------
To avoid this problem I am disabling the commissions by default in SVN rev 419413.
In this revision I just commented out line 33 of the accounting/servicedef/secas.xml file.
When this is fixed that should be uncommented, but not until because the newer commission code is breaking the pre-existing digital good sales code.
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: The Open For Business Project
> Type: Bug
> Components: accounting
> Versions: SVN trunk
> Reporter: David E. Jones
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=all ]
Si Chen reassigned OFBIZ-80:
----------------------------
Assignee: Si Chen
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: David E. Jones
> Assigned To: Si Chen
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-80) Bug in Commission code (showing in
getCommissionForProduct service)
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-80?page=all ]
Vinay Agarwal updated OFBIZ-80:
-------------------------------
Attachment: getCommissionForProduct06-08-28.patch
Fixed. It was caused by use of ServiceUtil.getPartyIdCheckSecurity for checking security. This function fails if "system" userLogin is used which has no partyId associated. The service now uses security.hasEntityPermission function.
Regards,
Vinay Agarwal
> Bug in Commission code (showing in getCommissionForProduct service)
> -------------------------------------------------------------------
>
> Key: OFBIZ-80
> URL: http://issues.apache.org/jira/browse/OFBIZ-80
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: David E. Jones
> Assigned To: Si Chen
> Attachments: getCommissionForProduct06-08-28.patch
>
>
> When an order is placed for a Digital Good, or any other ProductType that has isDigital attribute set to "Y", causes an error on checkout when the order is created. With this type of product an invoice is created immediately when the order is placed, and somehow that is getting down to the commission code with insufficient information.
> Here are a couple of messages from the log:
> 143489 (http-0.0.0.0-8443-Processor4) [ ServiceEcaRule.java:134:INFO ] Running Service ECA Service: createCommissionInvoices, triggered by rule on Service: createPaymentApplication
> 143523 (http-0.0.0.0-8443-Processor4) [ ServiceDispatcher.java:412:ERROR] Service Error [getCommissionForProduct]: Party ID missing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira