You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Charles Reiss (Created) (JIRA)" <ji...@apache.org> on 2012/01/22 21:42:48 UTC
[jira] [Created] (MESOS-129) j = j + 1 in Resources::isAllocatable
j = j + 1 in Resources::isAllocatable
-------------------------------------
Key: MESOS-129
URL: https://issues.apache.org/jira/browse/MESOS-129
Project: Mesos
Issue Type: Bug
Reporter: Charles Reiss
Assignee: Charles Reiss
Priority: Minor
common/resources.hpp has 'int j = j + 1' in for loop over Resources. This appears to occasionally (only if things get compiled "just right"?) cause a memory error that valgrind can find in some tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-129) j = j + 1 in
Resources::isAllocatable
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190845#comment-13190845 ]
jiraposter@reviews.apache.org commented on MESOS-129:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3583/#review4526
-----------------------------------------------------------
Ship it!
Wow, I thought this bug was fixed! Oh the perils of two different code repositories ... but no more! ;) I'll commit this right away. Thanks Charles.
- Benjamin
On 2012-01-22 20:44:30, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3583/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-22 20:44:30)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. int j = j + 1 didn't make any sense; I assume int i = i + 1 was meant so the check would be done on all pairs.
bq.
bq.
bq. This addresses bug MESOS-129.
bq. https://issues.apache.org/jira/browse/MESOS-129
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/common/resources.hpp 350e75d
bq.
bq. Diff: https://reviews.apache.org/r/3583/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> j = j + 1 in Resources::isAllocatable
> -------------------------------------
>
> Key: MESOS-129
> URL: https://issues.apache.org/jira/browse/MESOS-129
> Project: Mesos
> Issue Type: Bug
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Minor
>
> common/resources.hpp has 'int j = j + 1' in for loop over Resources. This appears to occasionally (only if things get compiled "just right"?) cause a memory error that valgrind can find in some tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-129) j = j + 1 in
Resources::isAllocatable
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190771#comment-13190771 ]
jiraposter@reviews.apache.org commented on MESOS-129:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3583/
-----------------------------------------------------------
Review request for mesos.
Summary
-------
int j = j + 1 didn't make any sense; I assume int i = i + 1 was meant so the check would be done on all pairs.
This addresses bug MESOS-129.
https://issues.apache.org/jira/browse/MESOS-129
Diffs
-----
src/common/resources.hpp 350e75d
Diff: https://reviews.apache.org/r/3583/diff
Testing
-------
Thanks,
Charles
> j = j + 1 in Resources::isAllocatable
> -------------------------------------
>
> Key: MESOS-129
> URL: https://issues.apache.org/jira/browse/MESOS-129
> Project: Mesos
> Issue Type: Bug
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Minor
>
> common/resources.hpp has 'int j = j + 1' in for loop over Resources. This appears to occasionally (only if things get compiled "just right"?) cause a memory error that valgrind can find in some tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (MESOS-129) j = j + 1 in Resources::isAllocatable
Posted by "Charles Reiss (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss closed MESOS-129.
-------------------------------
> j = j + 1 in Resources::isAllocatable
> -------------------------------------
>
> Key: MESOS-129
> URL: https://issues.apache.org/jira/browse/MESOS-129
> Project: Mesos
> Issue Type: Bug
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Minor
>
> common/resources.hpp has 'int j = j + 1' in for loop over Resources. This appears to occasionally (only if things get compiled "just right"?) cause a memory error that valgrind can find in some tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-129) j = j + 1 in Resources::isAllocatable
Posted by "Charles Reiss (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss resolved MESOS-129.
---------------------------------
Resolution: Fixed
> j = j + 1 in Resources::isAllocatable
> -------------------------------------
>
> Key: MESOS-129
> URL: https://issues.apache.org/jira/browse/MESOS-129
> Project: Mesos
> Issue Type: Bug
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Minor
>
> common/resources.hpp has 'int j = j + 1' in for loop over Resources. This appears to occasionally (only if things get compiled "just right"?) cause a memory error that valgrind can find in some tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira