[jira] [Commented] (ISIS-595) Validate metamodel to ensure that any bookmarkable actions are explicitly annotated as having safe action semantics.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826307#comment-13826307 ] 

ASF subversion and git services commented on ISIS-595:
------------------------------------------------------

Commit c713ad022a8cbe23d0a6aad910c6c32ba04f445e in branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c713ad0 ]

ISIS-595: updated BookmarkableAnnotationFacetFactory

as a MetaModelValidatorRefiner, to do the check:
- all @Bookmarkable(As.ROOT) or @Bookmarkable(As.CHILD) must also have
@ActionSemantics(Of.SAFE)


> Validate metamodel to ensure that any bookmarkable actions are explicitly annotated as having safe action semantics.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-595
>                 URL: https://issues.apache.org/jira/browse/ISIS-595
>             Project: Isis
>          Issue Type: New Feature
>          Components: Archetype: Simple WRJ, Core
>    Affects Versions: archetype-simple-wrj-1.3.1, core-1.3.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: archetype-simple-wrj-1.4.0, core-1.4.0
>
>
> Currently we silently ignore any actions that are bookmarkable but have non-safe action semantics.  While this is not dangerous behaviour, it is potentially confusing to the developer.
> Better to fail-fast during bootstrapping with an unambiguous error message.



--
This message was sent by Atlassian JIRA
(v6.1#6144)