You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Vamsee Yarlagadda <va...@cloudera.com> on 2017/06/07 22:26:52 UTC
Review Request 59897: SENTRY-1792: Ensure DB to sort delta changes by
CHANGE_ID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59897/
-----------------------------------------------------------
Review request for sentry and Alexander Kolbasov.
Repository: sentry
Description
-------
SENTRY-1795 has solved the issue of holes in the relevant tables. Instead of using auto-incrementing property, we now add the number along with the transaction itself. That being said, the current jira is mostly solved and the only thing that needs to be taken care of is to make sure the ID's returned from the DB are in order to avoid NN jumping the transaction ID's.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 37eb0b25e10ef69057599277aa5941ca05d52290
Diff: https://reviews.apache.org/r/59897/diff/1/
Testing
-------
Trivial fix
Thanks,
Vamsee Yarlagadda
Re: Review Request 59897: SENTRY-1792: Ensure DB to sort delta
changes by CHANGE_ID
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59897/#review177242
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On June 7, 2017, 10:26 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59897/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 10:26 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1795 has solved the issue of holes in the relevant tables. Instead of using auto-incrementing property, we now add the number along with the transaction itself. That being said, the current jira is mostly solved and the only thing that needs to be taken care of is to make sure the ID's returned from the DB are in order to avoid NN jumping the transaction ID's.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 37eb0b25e10ef69057599277aa5941ca05d52290
>
>
> Diff: https://reviews.apache.org/r/59897/diff/1/
>
>
> Testing
> -------
>
> Trivial fix
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>