You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/04/21 01:15:35 UTC

Review Request: SQOOP-1002 Sqoop2: Mapreduce local mode detection is not working correctly on Hadoop 2.x

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10687/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added framework detection. If it is set to "yarn" then we can't be running in mapreduce local mode.


This addresses bug SQOOP-1002.
    https://issues.apache.org/jira/browse/SQOOP-1002


Diffs
-----

  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 

Diff: https://reviews.apache.org/r/10687/diff/


Testing
-------

Unit and integration tests seems to be passing. In addition I've verified the functionality on real Hadoop 2.x cluster.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-1002 Sqoop2: Mapreduce local mode detection is not working correctly on Hadoop 2.x

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10687/#review20450
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On April 20, 2013, 11:15 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10687/
> -----------------------------------------------------------
> 
> (Updated April 20, 2013, 11:15 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added framework detection. If it is set to "yarn" then we can't be running in mapreduce local mode.
> 
> 
> This addresses bug SQOOP-1002.
>     https://issues.apache.org/jira/browse/SQOOP-1002
> 
> 
> Diffs
> -----
> 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 
> 
> Diff: https://reviews.apache.org/r/10687/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing. In addition I've verified the functionality on real Hadoop 2.x cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-1002 Sqoop2: Mapreduce local mode detection is not working correctly on Hadoop 2.x

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10687/#review19515
-----------------------------------------------------------

Ship it!


LGTM

- Venkat Ranganathan


On April 20, 2013, 11:15 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10687/
> -----------------------------------------------------------
> 
> (Updated April 20, 2013, 11:15 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added framework detection. If it is set to "yarn" then we can't be running in mapreduce local mode.
> 
> 
> This addresses bug SQOOP-1002.
>     https://issues.apache.org/jira/browse/SQOOP-1002
> 
> 
> Diffs
> -----
> 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 
> 
> Diff: https://reviews.apache.org/r/10687/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing. In addition I've verified the functionality on real Hadoop 2.x cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>