You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by anuragmath <gi...@git.apache.org> on 2017/01/04 14:12:47 UTC

[GitHub] incubator-fineract pull request #272: Merge pull request #1 from apache/deve...

GitHub user anuragmath opened a pull request:

    https://github.com/apache/incubator-fineract/pull/272

    Merge pull request #1 from apache/develop

    IF-21

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/upscaletech/incubator-fineract develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #272
    
----
commit 272b84f5dbfc9fc211fb27741f54772eb1b1106a
Author: Upscale Consultancy Services <sa...@theupscale.in>
Date:   2016-09-18T19:06:55Z

    Merge pull request #1 from apache/develop
    
    IF-21

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract issue #272: Merge pull request #1 from apache/develop

Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:

    https://github.com/apache/incubator-fineract/pull/272
  
    @anuragmath Can you mention Jira number as part of the PR. Without Jira details it will be difficult to validate the changes. PR should not have intelliJ files. Please send PR with single commit for cleaner history. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract issue #272: Merge pull request #1 from apache/develop

Posted by Ippezrobert <gi...@git.apache.org>.
Github user Ippezrobert commented on the issue:

    https://github.com/apache/incubator-fineract/pull/272
  
    @anuragmath I tested your PR and it only works for Savings Account but not Share Account, Can you please make necessary changes so that it extends to Share Accounts too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---