[jira] Updated: (CODEC-93) Add test(s) to check that encodeBase64() does not chunk output

["Julius Davies (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CODEC-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julius Davies updated CODEC-93:
-------------------------------

    Attachment: codec93-preserve-1.3-behaviour.patch

This patch contains 8 junits that will help us keep the behaviour of Base64 consistent with the original commons-codec-1.3 behaviour:

1.  Encoder.encode()
2.  Decoder.decode()
3.  BinaryEncoder.encode()
4.  BinaryEncoder.decode()
5.  Base64.encodeBase64()
6.  Base64.decodeBase64()
7.  Base64.encodeBase64Chunked()
8.  Base64.decodeBase64()  (against chunked input)


This particular test case can be run against commons-codec-1.3;


.
{noformat} 
├── commons-codec-1.3.jar
├── junit-3.8.1.jar
└── org
    └── apache
        └── commons
            └── codec
                └── binary
                    └── Base64Codec13Test.class


$ java -cp commons-codec-1.3.jar:junit-3.8.1.jar:. org.apache.commons.codec.binary.Base64Codec13Test 
8/8 tests succeeded!
{noformat}


I recommend that developers commit this patch immediately, because it will cause trunk to start failing, helping us to get the current codec-1.4 bugs fixed.



> Add test(s) to check that encodeBase64() does not chunk output
> --------------------------------------------------------------
>
>                 Key: CODEC-93
>                 URL: https://issues.apache.org/jira/browse/CODEC-93
>             Project: Commons Codec
>          Issue Type: Sub-task
>    Affects Versions: 1.4
>            Reporter: Sebb
>         Attachments: codec93-preserve-1.3-behaviour.patch
>
>
> There don't appear to be any tests to specifically check that encodeBase64(byte[]) does not chunk output.
> Also, there don't seem to be any direct tests of the following static method:
> encodeBase64(byte[] binaryData, boolean isChunked, boolean urlSafe)
> There are not many of some of the other static methods either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.