You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/10 01:53:12 UTC
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #288: webclient: Fix errno in case of recv failure
yamt opened a new pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643124742
@jerpelea
thank you.
i updated the PR description.
i'm not sure what's wrong with the commit message. have you looked at the latest one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea removed a comment on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea removed a comment on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643169608
@yamt
Here is how git log looks with and without messages since some commits were merged without messages.
commit 6f3cef856dda8063245cfdb030c791b7dbf3b163
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Mon Jun 8 17:10:52 2020 +0800
libc: Add the remaining wscanf series declaration
The function isn't implemented like other wide printf/scanf
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I0b26bb5174d1a9295fe2454d0e33f8227b8cbf8a
commit d0158fe8d8324dada35f7f0093ad658ac2663c73
Author: Masayuki Ishikawa <ma...@gmail.com>
Date: Mon Jun 8 12:37:54 2020 +0900
boards: Fix Kconfig for maix-bit with QEMU
Signed-off-by: Masayuki Ishikawa <Ma...@jp.sony.com>
commit 2b0324c3bfe7425a32e8cac846f1d463b46ec507
Author: Huang Qi <hu...@xiaomi.com>
Date: Sat Jun 6 13:18:14 2020 +0800
boards/risc-v/k210/maix-bit: Add initial autoled support
Signed-off-by: Huang Qi <hu...@xiaomi.com>
commit bcd7ccc0b5392279a159de056779830b57092eb2
Author: Huang Qi <hu...@xiaomi.com>
Date: Sat Jun 6 10:42:33 2020 +0800
arch/risc-v/src/k210: Add basic gpiohs support
Signed-off-by: Huang Qi <hu...@xiaomi.com>
commit 24262a4ddbccbd33d9020f6e783c94b2ce43cc8c
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sat Jun 6 21:16:53 2020 +0800
Fix nxstyle issue
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
commit 7a18ebe45980a80370b7afaa4b4d0be703402318
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sat Jun 6 18:35:44 2020 +0800
drivers/led: Extend userled_set_t from 8bits to 32bits
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I5701b42ff930998198b1d915316cc4f2d085d4eb
commit 76965474ac01aaceeb888cfd12c6051fc944906d
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Fri Jun 5 18:08:02 2020 +0800
drivers/led: Let board_userled_initialize return the led number
so the lower half driver don't need include the specific board.h
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: Icf6638a6865bac42150b5957376e55909f041d40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643171237
this commit is ok and you can understand what happened in that commit
"libc: Add the remaining wscanf series declaration
The function isn't implemented like other wide printf/scanf"
this commit is not ok because there is no message (just the title)
"arch/risc-v/src/k210: Add basic gpiohs support"
This one is also slightly wrong because the title sentence was written on 2 lines and the second one became the commit message.
"drivers/led: Let board_userled_initialize return the led number
so the lower half driver don't need include the specific board.h"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643119108
each commit should have a commit message describing the commit and when you create a push request you are asked to fill 3 fields
"Summary
Impact
Testing"
the commit message for this commit does not describe why the change is needed and there is no information provided in those 3 fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643131860
The commit message should provide some information why the change is needed or some background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-641754606
Please add PR and commit messages !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea removed a comment on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea removed a comment on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643171237
this commit is ok and you can understand what happened in that commit
"libc: Add the remaining wscanf series declaration
The function isn't implemented like other wide printf/scanf"
this commit is not ok because there is no message (just the title)
"arch/risc-v/src/k210: Add basic gpiohs support"
This one is also slightly wrong because the title sentence was written on 2 lines and the second one became the commit message.
"drivers/led: Let board_userled_initialize return the led number
so the lower half driver don't need include the specific board.h"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643136621
@yamt
Have a look at
https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
Or for more more details:
https://chris.beams.io/posts/git-commit/
Here are some examples of filling in the PR information:
https://github.com/apache/incubator-nuttx/pull/1196
https://github.com/apache/incubator-nuttx/pull/1147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643241754
> @jerpelea
> if it's important for the project, why don't you introduce mechanical enforcement?
> i think some projects do something along the line.
>
> (as you might guess, i personally don't love it too much though!)
Brother - if you only knew how this is a TFE discussion. Huge changes have been made to the code with no information or worse useless information. Your very well written and detailed explanation will help set an example. THANK YOU for it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643171587
@jerpelea
i don't see any obvious problems in the commit log.
anyway, i tried my best to the commit message longer. i hope you like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643113741
sorry, what do you mean by "Please add PR and commit messages !" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643178265
@jerpelea
if it's important for the project, why don't you introduce mechanical enforcement?
i think some projects do something along the line.
(as you might guess, i personally don't love it too much though!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643169608
@yamt
Here is how git log looks with and without messages since some commits were merged without messages.
commit 6f3cef856dda8063245cfdb030c791b7dbf3b163
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Mon Jun 8 17:10:52 2020 +0800
libc: Add the remaining wscanf series declaration
The function isn't implemented like other wide printf/scanf
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I0b26bb5174d1a9295fe2454d0e33f8227b8cbf8a
commit d0158fe8d8324dada35f7f0093ad658ac2663c73
Author: Masayuki Ishikawa <ma...@gmail.com>
Date: Mon Jun 8 12:37:54 2020 +0900
boards: Fix Kconfig for maix-bit with QEMU
Signed-off-by: Masayuki Ishikawa <Ma...@jp.sony.com>
commit 2b0324c3bfe7425a32e8cac846f1d463b46ec507
Author: Huang Qi <hu...@xiaomi.com>
Date: Sat Jun 6 13:18:14 2020 +0800
boards/risc-v/k210/maix-bit: Add initial autoled support
Signed-off-by: Huang Qi <hu...@xiaomi.com>
commit bcd7ccc0b5392279a159de056779830b57092eb2
Author: Huang Qi <hu...@xiaomi.com>
Date: Sat Jun 6 10:42:33 2020 +0800
arch/risc-v/src/k210: Add basic gpiohs support
Signed-off-by: Huang Qi <hu...@xiaomi.com>
commit 24262a4ddbccbd33d9020f6e783c94b2ce43cc8c
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sat Jun 6 21:16:53 2020 +0800
Fix nxstyle issue
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
commit 7a18ebe45980a80370b7afaa4b4d0be703402318
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sat Jun 6 18:35:44 2020 +0800
drivers/led: Extend userled_set_t from 8bits to 32bits
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I5701b42ff930998198b1d915316cc4f2d085d4eb
commit 76965474ac01aaceeb888cfd12c6051fc944906d
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Fri Jun 5 18:08:02 2020 +0800
drivers/led: Let board_userled_initialize return the led number
so the lower half driver don't need include the specific board.h
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: Icf6638a6865bac42150b5957376e55909f041d40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643594021
@davids5 what's "TFE"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643164172
are you seriously suggesting we need lengthy explanation for this simple fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 merged pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643174429
@yamt Thanks for your patience to fix this minor issue.
I think that is our job to help other developers on howto do a better documentation on their work so that everybody in the community can understand the changes.
Linux kernel is one of the biggest projects and a good source of inspiration regaring how a commit should be written.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=v5.7.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea edited a comment on pull request #288: webclient: Fix errno in case of recv failure
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #288:
URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643119108
**Requirements**
Each commit should have a commit message describing the commit
When you create a push request you are asked to fill 3 fields
"Summary
Impact
Testing"
**Issue**
The commit message for this commit does not describe why the change is needed and there is no information provided in those 3 fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org