[jira] Updated: (MASSEMBLY-152) Support Ant token

["John Franey (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MASSEMBLY-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Franey updated MASSEMBLY-152:
----------------------------------

    Attachment: ant-token-fix.diff

Here is a fix for 2.2-SNAPSHOT rev 508131.  Not only does it support ant tokens, but also the escape slash for microsoft paths specified in property files.

This fix involved copying over some lines of code from the resource plugin.  The thinking is that the behavior of resource plugin is desired and the easiest way is to reuse some implementation.  I'm still new to maven plugin development, and if there is some way to refactor this code without copy, I'm open for instruction.  In the meantime, the groundwork is here for migration to common filtering implementation that may become available.

Test cases are provided.

> Support Ant token
> -----------------
>
>                 Key: MASSEMBLY-152
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-152
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.2
>         Environment: Maven 2.0.4
>            Reporter: Rémy Sanlaville
>            Priority: Critical
>         Attachments: ant-token-fix.diff
>
>
> For the moment Maven 2.x Assembly Plugin support only maven token (${token})
> But I need to share some properties file with ant and maven.
> So It would be nice to also add Ant token support (@token@)
> For the version 2.1, I can give a patch
> The version 2.2-SNAPSHOT seems to be all refactoring and I don't have a patch for the moment.
> I think we have to look at the method private String filter( String rawContents ) of the org.apache.maven.plugin.assembly.format.FileFormatter class. But I don't know how the RegexBasedInterpolator class works.
> Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira