[jira] [Commented] (MSITE-752) Cannot use server side includes.

["Christian Schulte (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSITE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036078#comment-15036078 ] 

Christian Schulte commented on MSITE-752:
-----------------------------------------

{code}
Failed tests: 
  XhtmlBaseSinkTest.testComment:925 expected:<<!--[ a comment ]-->> but was:<<!--[a comment]-->>
  XhtmlBaseSinkTest.testLineBreak:853 expected:<... style="bold" /><!--[ PB ]-->&#160;> but was:<... style="bold" /><!--[PB]-->&#160;>
{code}

I am not sure this can be changed in a backward compatible way. Maybe the parser should be updated to handle the

{code}
<!--#
{code}

as a special directive?


> Cannot use server side includes.
> --------------------------------
>
>                 Key: MSITE-752
>                 URL: https://issues.apache.org/jira/browse/MSITE-752
>             Project: Maven Site Plugin
>          Issue Type: Bug
>    Affects Versions: 3.4
>         Environment: Java version: 1.8.0_45, vendor: Oracle Corporation
> Java home: /usr/local/jdk-1.8.0/jre
> Default locale: de_DE, platform encoding: UTF-8
>            Reporter: Christian Schulte
>         Attachments: MSITE-752.zip
>
>
> Please see the attached example project. The 'index.xml' document contains some server side include directives. Executing 'mvn site', the server side includes won't work as the comments have been processed in a way that
> {code}
> <!--#set var="code" value="" -->
> {code}
>  becomes
> {code}
> <!-- #set var="code" value="" -->
> {code}
> Note the extra space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)