You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/09/23 19:11:52 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1378: GROOVY-9757: run test closure only for containing source unit
eric-milles opened a new pull request #1378:
URL: https://github.com/apache/groovy/pull/1378
This replaces progress callback chaining with new phase operations. These are run one step before the progress callback, but should come after all other phase operations under normal circumstances. Using a source operation makes limiting to the desired source unit trivial and makes the scheduling for multiple phases (null phase member) much more obvious.
It still would be nice to be able to have the test code run after the compilation unit has its phase marked completed (`completePhase()` in `CompilationUnit`) and after the source unit(s) have their phase incremented and completed (`mark()` in `CompilationUnit`). But I think that would require some custom changes to CompUnit.
- added error for early phase request
https://issues.apache.org/jira/browse/GROOVY-9757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles merged pull request #1378: GROOVY-9757: run test closure only for containing source unit
Posted by GitBox <gi...@apache.org>.
eric-milles merged pull request #1378:
URL: https://github.com/apache/groovy/pull/1378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org