You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Alexander Broekhuis <a....@gmail.com> on 2013/09/20 10:14:43 UTC
Re: [ CELIX ]: Contributing
Hi Celix folks,
Just a question regarding this code. It is a fairly big addition, is this
patch good enough? Or is a code grand more in place?
I am fine with this patch, but maybe from a license/tracking point of view
something else is needed..
If this is ok as it is now, I will add the code to the repo. Reading the
issue, it is not finished, but I don't see that as a big problem. It won't
break any of the existing functionality and the config admin is a nice
addition to what we already have.
2013/8/11 Jorge SANCHEZ <js...@gmail.com>
> Hi all,
>
> The issue's number is CELIX-77 and the work is attached in a zip file in
> the issue. The link to the issue is:
>
> https://issues.apache.org/**jira/browse/CELIX-77<https://issues.apache.org/jira/browse/CELIX-77>
>
> Greetings,
> Jorge
>
>
>
> On 08/11/2013 12:07 PM, Mohammad Nour El-Din wrote:
>
>> Hi
>>
>> @Pepijn: Welcome back ;)
>>
>>
>> @Jorge: Great news. As a friendly note, it would be better to mention the
>> JIRA issue's number that you are working on and attached your patch to so
>> you give a better chance for your work to be reviewed by more people and
>> hence either get committed fast or you get feedback soon enough. But other
>> than that great work ;)
>>
>>
>> On Sat, Aug 10, 2013 at 8:46 PM, Pepijn Noltes <pepijnnoltes@gmail.com
>> >wrote:
>>
>> Hi Jorge,
>>>
>>> On Sat, Aug 10, 2013 at 2:08 PM, Jorge SANCHEZ <js...@gmail.com>
>>> wrote:
>>>
>>>> I uploaded my work. Sorry for the delay, I went on holidays, busy new
>>>>
>>> city
>>>
>>>> moving, new assignment, ... but the most important, the work is in JIRA
>>>>
>>> ;).
>>>
>>> Good news. Thanks for donating your work to Celix :)
>>> When I have time I will review, discuss and/or commit the code. I will
>>> probably start with this next week, after my holiday.
>>>
>>> Greetings,
>>> Pepijn
>>>
>>>
>>> Friendly greetings,
>>>> Jorge
>>>>
>>>>
>>>>
>>>> On 07/30/2013 05:14 PM, Mohammad Nour El-Din wrote:
>>>>
>>>>> Hi Jorge
>>>>>
>>>>> Nice to see you on the mailing list ;)
>>>>>
>>>>> What I suggest you to do is to JIRA at [1], create an account for JIRA
>>>>>
>>>> if
>>>
>>>> you don't already have one, look if there is already a JIRA issue
>>>>>
>>>> related
>>>
>>>> to the work you have done, if not create one and give it some good
>>>>> description then attach a patch to it and eventually someone with
>>>>> commit
>>>>> rights should pick it up, review it and then commit it for you
>>>>>
>>>>> If there is already a JIRA related to what you have done just attach
>>>>> the
>>>>> patch file it
>>>>>
>>>>> In either case also add a comment explaining what you have done in the
>>>>> patch. I would also be much better you besides that you send an e-mail
>>>>>
>>>> to
>>>
>>>> this mailing list explaining the changes you have made, any impacts if
>>>>> any,
>>>>> etc...
>>>>>
>>>>> For the license header thing, you are basicly right, but the committer
>>>>>
>>>> who
>>>
>>>> will pick you patch should also review these aspect and give you a
>>>>> feedback
>>>>> and by time you will learn ;). It is also good to read [2] for general
>>>>> information about contribution
>>>>>
>>>>> Have fun ;)
>>>>>
>>>>> [1] https://issues.apache.org/**jira/browse/CELIX<https://issues.apache.org/jira/browse/CELIX>
>>>>> [2] http://www.apache.org/dev/#**committers<http://www.apache.org/dev/#committers>
>>>>>
>>>>> On Sun, Jul 28, 2013 at 10:51 AM, Jorge SM <js...@gmail.com> wrote:
>>>>>
>>>>> Hi all,
>>>>>>
>>>>>> I´m Jorge. I was trainee at Thales not so far (my supervisor was
>>>>>> Pepijn
>>>>>> Noltes, already member of Celix) and I would like to contribute myself
>>>>>>
>>>>> my
>>>
>>>> work done in Thales. Giving more info of my work, I started an
>>>>>> implementation of the ConfigAdmin Service. I'd like if anyone can
>>>>>> teach
>>>>>> me
>>>>>> how to solve the problem of licenses and what shall I do to give
>>>>>> freely
>>>>>> my
>>>>>> work to the community, I'm newbie in all this and I don´t have it
>>>>>> clear
>>>>>> yet, I´m only aware, please correct me if I' wrong, that I´m have to
>>>>>> include a specific block text at the beginning of every header file,
>>>>>> in
>>>>>> any
>>>>>> case with your help you will show what to do and what is best.
>>>>>>
>>>>>> Friendly greetings,
>>>>>> Jorge
>>>>>>
>>>>>>
>>>>>
>>
>>
>
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [ CELIX ]: Contributing
Posted by Marcel Offermans <ma...@luminis.nl>.
If I compare this project to Felix, we usually have people send a grant if a complete bundle (or something bigger) is donated to the project. It sounds reasonable to use the same policy here.
Since the project team has dealt with accepting such contributions before (and the process of sending a grant) I assume for now that you guys can handle this, but if there are any further questions, don't hesitate to ask/ping!
Greetings, Marcel
On Sep 24, 2013, at 13:58 PM, Alexander Broekhuis <a....@gmail.com> wrote:
> Hi Jorge,
>
>
>>
>> As reporter of the ticket in Jira what I could say is that as starting the
>> code it's good enough and Pepijn has offered himself to review it.
>>
>> My concern isn't with the code, but more with the procedure to follow. As
> Pepijn already mentioned, for larger parts of code a grant is often used.
>
>
>>
>>>
>>> I am fine with this patch, but maybe from a license/tracking point of
>> view
>>> something else is needed..
>>>
>>
>> About license, I'm very lost, if there is something that needs to come from
>> me, please let me know, I'd be pleased to help :)
>>
>
> Basically it has to do with what you are contributing. In this case it is a
> completely new bundle, and not as much a bugfix/patch for existing code. So
> from a license point of view it probably makes more sense to offer this
> code with a grant instead of only the current sources.
>
> But lets wait for one of our mentors (or other ipmc followers on this list)
> to reply and help us out.
>
>
>
>>
>> Yes, the code is not finished, but the implemented parts behave as SPECs
>> says, if someone needs some specific info of the work, the description of
>> the issue [1] gives an insight, but if anyone is eager to know more, please
>> ask.
>>
>
> Will do, don't worry ;).
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
Re: [ CELIX ]: Contributing
Posted by Alexander Broekhuis <a....@gmail.com>.
Hi Jorge,
>
> As reporter of the ticket in Jira what I could say is that as starting the
> code it's good enough and Pepijn has offered himself to review it.
>
> My concern isn't with the code, but more with the procedure to follow. As
Pepijn already mentioned, for larger parts of code a grant is often used.
>
> >
> > I am fine with this patch, but maybe from a license/tracking point of
> view
> > something else is needed..
> >
>
> About license, I'm very lost, if there is something that needs to come from
> me, please let me know, I'd be pleased to help :)
>
Basically it has to do with what you are contributing. In this case it is a
completely new bundle, and not as much a bugfix/patch for existing code. So
from a license point of view it probably makes more sense to offer this
code with a grant instead of only the current sources.
But lets wait for one of our mentors (or other ipmc followers on this list)
to reply and help us out.
>
> Yes, the code is not finished, but the implemented parts behave as SPECs
> says, if someone needs some specific info of the work, the description of
> the issue [1] gives an insight, but if anyone is eager to know more, please
> ask.
>
Will do, don't worry ;).
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [ CELIX ]: Contributing
Posted by Pepijn Noltes <pe...@gmail.com>.
Hi All,
On Fri, Sep 20, 2013 at 2:16 PM, Jorge SM <js...@gmail.com> wrote:
> Hi all :),
>
> 2013/9/20 Alexander Broekhuis <a....@gmail.com>
>
>> Hi Celix folks,
>>
>> Just a question regarding this code. It is a fairly big addition, is this
>> patch good enough? Or is a code grand more in place?
>>
>
Good point, I though we didn't need a grant based on the mail
discussion in [1]. But reading it again; I see a ICLA is not needed,
but because the code is developed @ Thales a software grant is
probably needed? Maybe one of the mentors answer this?
For info, technically is it not a problem to get a software grant for
this patch. We already did this for the device access donation.
[1] http://markmail.org/message/slbnxokeht5maymt
>
>
>>
>> I am fine with this patch, but maybe from a license/tracking point of view
>> something else is needed..
>>
>
> About license, I'm very lost, if there is something that needs to come from
> me, please let me know, I'd be pleased to help :)
>
>
>>
>> If this is ok as it is now, I will add the code to the repo. Reading the
>> issue, it is not finished, but I don't see that as a big problem.
>
>
> Yes, the code is not finished, but the implemented parts behave as SPECs
> says, if someone needs some specific info of the work, the description of
> the issue [1] gives an insight, but if anyone is eager to know more, please
> ask.
>
>
>> It won't
>> break any of the existing functionality and the config admin is a nice
>> addition to what we already have.
>
>
> Friendly greetings,
> Jorge SANCHEZ
>
>
Re: [ CELIX ]: Contributing
Posted by Jorge SM <js...@gmail.com>.
Hi all :),
2013/9/20 Alexander Broekhuis <a....@gmail.com>
> Hi Celix folks,
>
> Just a question regarding this code. It is a fairly big addition, is this
> patch good enough? Or is a code grand more in place?
>
As reporter of the ticket in Jira what I could say is that as starting the
code it's good enough and Pepijn has offered himself to review it.
>
> I am fine with this patch, but maybe from a license/tracking point of view
> something else is needed..
>
About license, I'm very lost, if there is something that needs to come from
me, please let me know, I'd be pleased to help :)
>
> If this is ok as it is now, I will add the code to the repo. Reading the
> issue, it is not finished, but I don't see that as a big problem.
Yes, the code is not finished, but the implemented parts behave as SPECs
says, if someone needs some specific info of the work, the description of
the issue [1] gives an insight, but if anyone is eager to know more, please
ask.
> It won't
> break any of the existing functionality and the config admin is a nice
> addition to what we already have.
Friendly greetings,
Jorge SANCHEZ
[1] CELIX issue 77 - https://issues.apache.org/jira/browse/CELIX-77
>
>
> 2013/8/11 Jorge SANCHEZ <js...@gmail.com>
>
> > Hi all,
> >
> > The issue's number is CELIX-77 and the work is attached in a zip file in
> > the issue. The link to the issue is:
> >
> > https://issues.apache.org/**jira/browse/CELIX-77<
> https://issues.apache.org/jira/browse/CELIX-77>
> >
> > Greetings,
> > Jorge
> >
> >
> >
> > On 08/11/2013 12:07 PM, Mohammad Nour El-Din wrote:
> >
> >> Hi
> >>
> >> @Pepijn: Welcome back ;)
> >>
> >>
> >> @Jorge: Great news. As a friendly note, it would be better to mention
> the
> >> JIRA issue's number that you are working on and attached your patch to
> so
> >> you give a better chance for your work to be reviewed by more people and
> >> hence either get committed fast or you get feedback soon enough. But
> other
> >> than that great work ;)
> >>
> >>
> >> On Sat, Aug 10, 2013 at 8:46 PM, Pepijn Noltes <pepijnnoltes@gmail.com
> >> >wrote:
> >>
> >> Hi Jorge,
> >>>
> >>> On Sat, Aug 10, 2013 at 2:08 PM, Jorge SANCHEZ <js...@gmail.com>
> >>> wrote:
> >>>
> >>>> I uploaded my work. Sorry for the delay, I went on holidays, busy new
> >>>>
> >>> city
> >>>
> >>>> moving, new assignment, ... but the most important, the work is in
> JIRA
> >>>>
> >>> ;).
> >>>
> >>> Good news. Thanks for donating your work to Celix :)
> >>> When I have time I will review, discuss and/or commit the code. I will
> >>> probably start with this next week, after my holiday.
> >>>
> >>> Greetings,
> >>> Pepijn
> >>>
> >>>
> >>> Friendly greetings,
> >>>> Jorge
> >>>>
> >>>>
> >>>>
> >>>> On 07/30/2013 05:14 PM, Mohammad Nour El-Din wrote:
> >>>>
> >>>>> Hi Jorge
> >>>>>
> >>>>> Nice to see you on the mailing list ;)
> >>>>>
> >>>>> What I suggest you to do is to JIRA at [1], create an account for
> JIRA
> >>>>>
> >>>> if
> >>>
> >>>> you don't already have one, look if there is already a JIRA issue
> >>>>>
> >>>> related
> >>>
> >>>> to the work you have done, if not create one and give it some good
> >>>>> description then attach a patch to it and eventually someone with
> >>>>> commit
> >>>>> rights should pick it up, review it and then commit it for you
> >>>>>
> >>>>> If there is already a JIRA related to what you have done just attach
> >>>>> the
> >>>>> patch file it
> >>>>>
> >>>>> In either case also add a comment explaining what you have done in
> the
> >>>>> patch. I would also be much better you besides that you send an
> e-mail
> >>>>>
> >>>> to
> >>>
> >>>> this mailing list explaining the changes you have made, any impacts if
> >>>>> any,
> >>>>> etc...
> >>>>>
> >>>>> For the license header thing, you are basicly right, but the
> committer
> >>>>>
> >>>> who
> >>>
> >>>> will pick you patch should also review these aspect and give you a
> >>>>> feedback
> >>>>> and by time you will learn ;). It is also good to read [2] for
> general
> >>>>> information about contribution
> >>>>>
> >>>>> Have fun ;)
> >>>>>
> >>>>> [1] https://issues.apache.org/**jira/browse/CELIX<
> https://issues.apache.org/jira/browse/CELIX>
> >>>>> [2] http://www.apache.org/dev/#**committers<
> http://www.apache.org/dev/#committers>
> >>>>>
> >>>>> On Sun, Jul 28, 2013 at 10:51 AM, Jorge SM <js...@gmail.com>
> wrote:
> >>>>>
> >>>>> Hi all,
> >>>>>>
> >>>>>> I´m Jorge. I was trainee at Thales not so far (my supervisor was
> >>>>>> Pepijn
> >>>>>> Noltes, already member of Celix) and I would like to contribute
> myself
> >>>>>>
> >>>>> my
> >>>
> >>>> work done in Thales. Giving more info of my work, I started an
> >>>>>> implementation of the ConfigAdmin Service. I'd like if anyone can
> >>>>>> teach
> >>>>>> me
> >>>>>> how to solve the problem of licenses and what shall I do to give
> >>>>>> freely
> >>>>>> my
> >>>>>> work to the community, I'm newbie in all this and I don´t have it
> >>>>>> clear
> >>>>>> yet, I´m only aware, please correct me if I' wrong, that I´m have to
> >>>>>> include a specific block text at the beginning of every header file,
> >>>>>> in
> >>>>>> any
> >>>>>> case with your help you will show what to do and what is best.
> >>>>>>
> >>>>>> Friendly greetings,
> >>>>>> Jorge
> >>>>>>
> >>>>>>
> >>>>>
> >>
> >>
> >
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>