You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/30 07:50:15 UTC

[GitHub] [spark] beliefer opened a new pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

beliefer opened a new pull request #30543:
URL: https://github.com/apache/spark/pull/30543


   ### What changes were proposed in this pull request?
   There are a lot of mainstream databases support regex function `REGEXP_LIKE`.
   Currently, Spark supports `RLike` and we just need add a new alias `REGEXP_LIKE` for it.
   **Oracle**
   https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Pattern-matching-Conditions.html#GUID-D2124F3A-C6E4-4CCA-A40E-2FFCABFD8E19
   **Presto**
   https://prestodb.io/docs/current/functions/regexp.html
   **Vertica**
   https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/SQLReferenceManual/Functions/RegularExpressions/REGEXP_LIKE.htm?tocpath=SQL%20Reference%20Manual%7CSQL%20Functions%7CRegular%20Expression%20Functions%7C_____5
   **Snowflake**
   https://docs.snowflake.com/en/sql-reference/functions/regexp_like.html
   
   
   ### Why are the changes needed?
   No
   
   
   ### Does this PR introduce _any_ user-facing change?
   Make the behavior of Spark SQL consistent with mainstream databases.
   
   
   ### How was this patch tested?
   Jenkins test
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736926495


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739662883


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36920/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739764695


   **[Test build #132348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132348/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737649749


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36682/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735742670


   **[Test build #131971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131971/testReport)** for PR 30543 at commit [`b31e12d`](https://github.com/apache/spark/commit/b31e12df146dd5ba85c3e03c8a1dea42d07aa5b2).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739801834


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742238339


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37138/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741590151


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741713314


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37089/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737105498






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737638526


   **[Test build #132083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132083/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747193399


   **[Test build #132923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132923/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737657381






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742239909


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37138/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741690534


   **[Test build #132487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132487/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737691325






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-744217896


   cc @cloud-fan @HyukjinKwon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737858245


   cc @maropu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r538364083



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       What do you mean? I meant the current generated doc is incorrect (`str regexp_like regex` in the usage);
   
   <img width="500" alt="Screen Shot 2020-12-08 at 22 14 34" src="https://user-images.githubusercontent.com/692303/101488973-9e1bb300-39a3-11eb-92bc-9d0f654afae4.png">
   
   ```
   scala> sql("select 'aaa' regexp_like 'aaa'").show()
   org.apache.spark.sql.catalyst.parser.ParseException:
   extraneous input ''aaa'' expecting {<EOF>, ';'}(line 1, pos 25)
   
   == SQL ==
   select 'aaa' regexp_like 'aaa'
   -------------------------^^^
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739920751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132348/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742198520






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742219519


   **[Test build #132534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132534/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r537507383



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       hm, since RLIKE/LIKE syntaxes are already documented in [the SQL doc](https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-like.html) , how about updating the usage (`str _FUNC_ regexp` -> `_FUNC_(str, regext)`) accordingly? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30543:
URL: https://github.com/apache/spark/pull/30543


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742197654


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37130/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737679077


   **[Test build #132083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132083/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742180015


   **[Test build #132528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132528/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741746429


   **[Test build #132487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132487/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736959996






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736359653


   Jenkins is down now, so could you re-invoke the GA tests?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741594157


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132470/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737638526


   **[Test build #132083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132083/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r537979256



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       `[ NOT ] { LIKE search_pattern [ ESCAPE esc_char ] | [ RLIKE | REGEXP ] regex_pattern }` is a syntax, but `_FUNC_(str, regext)` is a function call.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741602019


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736994991


   **[Test build #132009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132009/testReport)** for PR 30543 at commit [`6a6757a`](https://github.com/apache/spark/commit/6a6757a3395fdf3599e2b29202f14825d5418a44).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736296744


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735668838






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739654788


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36920/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736995489






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747854238


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37584/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747204578


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747210304


   **[Test build #132932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132932/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741568917


   **[Test build #132470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132470/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747203804


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37525/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739801816


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737105498






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737717106






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747842248


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747462249


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132946/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747343864


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37549/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737691325






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736927308


   **[Test build #132009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132009/testReport)** for PR 30543 at commit [`6a6757a`](https://github.com/apache/spark/commit/6a6757a3395fdf3599e2b29202f14825d5418a44).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747283906


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132932/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747258020


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37535/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747283906


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132932/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747864290


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37584/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747872792


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37584/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747209129






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747314444


   **[Test build #132946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132946/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739764695


   **[Test build #132348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132348/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741746908


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132487/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735755482






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735749223


   You forget to update the golden file. Anyway, the alias looks fine to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736942423


   > I meant the GitHub Actions tests. Its okay just to push an empty commit to invoke the tests. To merge a PR, either Jenkins tests or GA tests need to pass.
   
   Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736176772


   > You forget to update the golden file. Anyway, the alias looks fine to me.
   
   Thanks for your remind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r537507383



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       hm, since RLIKE/LIKE syntaxes are already documented in [the SQL doc](https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-like.html) , how about updating the usage (`str _FUNC_ regexp` -> `_FUNC_(str, regext)`), too? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747258020


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37535/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747929423


   **[Test build #132984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132984/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class SparkPod(pod: Pod, container: Container) `
     * `trait KubernetesFeatureConfigStep `
     * `public class Distributions `
     * `trait CheckAnalysis extends PredicateHelper with LookupCatalog `
     * `case class UnresolvedView(`
     * `case class Decode(params: Seq[Expression], child: Expression) extends RuntimeReplaceable `
     * `case class StringDecode(bin: Expression, charset: Expression)`
     * `case class NoopCommand(`
     * `case class ShowTableExtended(`
     * `case class AlterTableRecoverPartitions(child: LogicalPlan) extends Command `
     * `case class DropView(`
     * `case class RepairTable(child: LogicalPlan) extends Command `
     * `case class AlterViewAs(`
     * `case class AlterViewSetProperties(`
     * `case class AlterViewUnsetProperties(`
     * `case class CacheTable(`
     * `case class CacheTableAsSelect(`
     * `case class UncacheTable(`
     * `case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int] = None)`
     * `trait BaseCacheTableExec extends V2CommandExec `
     * `case class CacheTableExec(`
     * `case class CacheTableAsSelectExec(`
     * `case class UncacheTableExec(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747210304


   **[Test build #132932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132932/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739642610


   **[Test build #132320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132320/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-748092979


   thanks, merging to master!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736927308


   **[Test build #132009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132009/testReport)** for PR 30543 at commit [`6a6757a`](https://github.com/apache/spark/commit/6a6757a3395fdf3599e2b29202f14825d5418a44).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736564919


   I meant the GitHub Actions tests. Its okay just to push an empty commit to invoke the tests. To merge a PR, either Jenkins tests or GA tests need to pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739920751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132348/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741586918


   **[Test build #132470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132470/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739744608


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742198520






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741727047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37089/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747939105


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132984/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747443112


   **[Test build #132946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132946/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).
    * This patch **fails SparkR unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class SparkPod(pod: Pod, container: Container) `
     * `trait KubernetesFeatureConfigStep `
     * `public class Distributions `
     * `trait CheckAnalysis extends PredicateHelper with LookupCatalog `
     * `case class UnresolvedView(`
     * `case class Decode(params: Seq[Expression], child: Expression) extends RuntimeReplaceable `
     * `case class StringDecode(bin: Expression, charset: Expression)`
     * `case class NoopCommand(`
     * `case class ShowTableExtended(`
     * `case class AlterTableRecoverPartitions(child: LogicalPlan) extends Command `
     * `case class DropView(`
     * `case class RepairTable(child: LogicalPlan) extends Command `
     * `case class AlterViewAs(`
     * `case class AlterViewSetProperties(`
     * `case class AlterViewUnsetProperties(`
     * `case class CacheTable(`
     * `case class CacheTableAsSelect(`
     * `case class UncacheTable(`
     * `case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int] = None)`
     * `trait BaseCacheTableExec extends V2CommandExec `
     * `case class CacheTableExec(`
     * `case class CacheTableAsSelectExec(`
     * `case class UncacheTableExec(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737717106






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747872792


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37584/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735635781


   **[Test build #131971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131971/testReport)** for PR 30543 at commit [`b31e12d`](https://github.com/apache/spark/commit/b31e12df146dd5ba85c3e03c8a1dea42d07aa5b2).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737692642


   **[Test build #132097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132097/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737854869






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739801834


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r538365487



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       And, the column name below looks weird;
   ```
   scala> sql("select regexp_like('aaa', 'aaa')").show()
   +-------------------+                                                           
   |aaa REGEXP_LIKE aaa| --> should be REGEXP_LIKE(aaa, aaa)?
   +-------------------+
   |               true|
   +-------------------+
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739675063






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736361112


   > Jenkins is down now, so could you re-invoke the GA tests?
   
   I'm sorry! What is GA tests?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737222181






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737692642


   **[Test build #132097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132097/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741568917


   **[Test build #132470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132470/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747209129






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747939105


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132984/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739670658


   **[Test build #132320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132320/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class OneVsRest(Estimator, _OneVsRestParams, HasParallelism, MLReadable, MLWritable):`
     * `class OneVsRestReader(MLReader):`
     * `class OneVsRestWriter(MLWriter):`
     * `class OneVsRestModel(Model, _OneVsRestParams, MLReadable, MLWritable):`
     * `class OneVsRestModelReader(MLReader):`
     * `class OneVsRestModelWriter(MLWriter):`
     * `class CrossValidatorReader(MLReader):`
     * `class CrossValidatorWriter(MLWriter):`
     * `class CrossValidatorModelReader(MLReader):`
     * `class CrossValidatorModelWriter(MLWriter):`
     * `class TrainValidationSplitReader(MLReader):`
     * `class TrainValidationSplitWriter(MLWriter):`
     * `class TrainValidationSplitModelReader(MLReader):`
     * `class TrainValidationSplitModelWriter(MLWriter):`
     * `case class TemporaryViewRelation(tableMeta: CatalogTable) extends LeafNode `
     * `case class DateFromUnixDate(child: Expression) extends UnaryExpression`
     * `case class UnixDate(child: Expression) extends UnaryExpression`
     * `class JDBCTableCatalog extends TableCatalog with SupportsNamespaces with Logging `
     * `case class StateSchemaNotCompatible(message: String) extends Exception(message)`
     * `class StateSchemaCompatibilityChecker(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742197004


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37130/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741594157


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132470/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741679194


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741727047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37089/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741727026


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37089/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747193399


   **[Test build #132923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132923/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747462249


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132946/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747202037


   **[Test build #132923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132923/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735635781


   **[Test build #131971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131971/testReport)** for PR 30543 at commit [`b31e12d`](https://github.com/apache/spark/commit/b31e12df146dd5ba85c3e03c8a1dea42d07aa5b2).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741602048


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742219519


   **[Test build #132534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132534/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737068174


   **[Test build #132032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132032/testReport)** for PR 30543 at commit [`0680a4b`](https://github.com/apache/spark/commit/0680a4bee4adda43780d54328a01b99680b30c48).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737222181






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736995489






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742364091


   **[Test build #132534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132534/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-736959996






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737657381






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739787124


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737852245


   **[Test build #132097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132097/testReport)** for PR 30543 at commit [`280d4c9`](https://github.com/apache/spark/commit/280d4c99fe95b572018b42dc889e9156a154a029).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741690534


   **[Test build #132487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132487/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742180015


   **[Test build #132528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132528/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742373177


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132534/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741602048


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r538991640



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -348,11 +348,11 @@ case class NotLikeAny(child: Expression, patterns: Seq[UTF8String]) extends Like
     Examples:
       > SET spark.sql.parser.escapedStringLiterals=true;
       spark.sql.parser.escapedStringLiterals	true
-      > SELECT '%SystemDrive%\Users\John' _FUNC_ '%SystemDrive%\\Users.*';
+      > SELECT _FUNC_('%SystemDrive%\Users\John', '%SystemDrive%\\Users.*');

Review comment:
       I understand your mean now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747195377


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37525/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737679913


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739901474


   **[Test build #132348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132348/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class OneVsRest(Estimator, _OneVsRestParams, HasParallelism, MLReadable, MLWritable):`
     * `class OneVsRestReader(MLReader):`
     * `class OneVsRestWriter(MLWriter):`
     * `class OneVsRestModel(Model, _OneVsRestParams, MLReadable, MLWritable):`
     * `class OneVsRestModelReader(MLReader):`
     * `class OneVsRestModelWriter(MLWriter):`
     * `class CrossValidatorReader(MLReader):`
     * `class CrossValidatorWriter(MLWriter):`
     * `class CrossValidatorModelReader(MLReader):`
     * `class CrossValidatorModelWriter(MLWriter):`
     * `class TrainValidationSplitReader(MLReader):`
     * `class TrainValidationSplitWriter(MLWriter):`
     * `class TrainValidationSplitModelReader(MLReader):`
     * `class TrainValidationSplitModelWriter(MLWriter):`
     * `case class TemporaryViewRelation(tableMeta: CatalogTable) extends LeafNode `
     * `case class DateFromUnixDate(child: Expression) extends UnaryExpression`
     * `case class UnixDate(child: Expression) extends UnaryExpression`
     * `class JDBCTableCatalog extends TableCatalog with SupportsNamespaces with Logging `
     * `case class StateSchemaNotCompatible(message: String) extends Exception(message)`
     * `class StateSchemaCompatibilityChecker(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747843272


   **[Test build #132984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132984/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737068174


   **[Test build #132032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132032/testReport)** for PR 30543 at commit [`0680a4b`](https://github.com/apache/spark/commit/0680a4bee4adda43780d54328a01b99680b30c48).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747311692


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742192987


   **[Test build #132528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132528/testReport)** for PR 30543 at commit [`dc4f946`](https://github.com/apache/spark/commit/dc4f9463584b416549a8c0fad18d0f1a829ee839).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739675063






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735755482






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747343864


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37549/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30543:
URL: https://github.com/apache/spark/pull/30543#discussion_r545840086



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -364,7 +364,8 @@ case class RLike(left: Expression, right: Expression) extends StringRegexExpress
 
   override def escape(v: String): String = v
   override def matches(regex: Pattern, str: String): Boolean = regex.matcher(str).find(0)
-  override def toString: String = s"$left RLIKE $right"

Review comment:
       we should also override `prettyName`, similar to average: `override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("avg")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737854869






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737657369


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36682/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747314444


   **[Test build #132946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132946/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742373177


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132534/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747283574


   **[Test build #132932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132932/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742205490


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742178330


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-737216957


   **[Test build #132032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132032/testReport)** for PR 30543 at commit [`0680a4b`](https://github.com/apache/spark/commit/0680a4bee4adda43780d54328a01b99680b30c48).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742239930


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37138/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-741746908


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132487/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-739642610


   **[Test build #132320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132320/testReport)** for PR 30543 at commit [`296ced9`](https://github.com/apache/spark/commit/296ced92017c4ee55c1b2ab57036e0e794d4fd1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-735668838






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-742239930


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37138/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30543: [SPARK-33597][SQL] Support REGEXP_LIKE for consistent with mainstream databases

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30543:
URL: https://github.com/apache/spark/pull/30543#issuecomment-747843272


   **[Test build #132984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132984/testReport)** for PR 30543 at commit [`e1cd719`](https://github.com/apache/spark/commit/e1cd719a0996c7bc3d74f7002393bad44000e4be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org