You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/09/10 13:20:02 UTC

svn commit: r1760160 - in /jmeter/trunk: bin/report-template/content/js/graph.js.fmkr bin/report-template/content/pages/ResponseTimes.html.fmkr xdocs/changes.xml

Author: pmouawad
Date: Sat Sep 10 13:20:02 2016
New Revision: 1760160

URL: http://svn.apache.org/viewvc?rev=1760160&view=rev
Log:
Bug 60110 - Report / Dashboard : In Response Time Percentiles, slider is useless
Bugzilla Id: 60110

Modified:
    jmeter/trunk/bin/report-template/content/js/graph.js.fmkr
    jmeter/trunk/bin/report-template/content/pages/ResponseTimes.html.fmkr
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/bin/report-template/content/js/graph.js.fmkr
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/report-template/content/js/graph.js.fmkr?rev=1760160&r1=1760159&r2=1760160&view=diff
==============================================================================
--- jmeter/trunk/bin/report-template/content/js/graph.js.fmkr (original)
+++ jmeter/trunk/bin/report-template/content/js/graph.js.fmkr Sat Sep 10 13:20:02 2016
@@ -37,7 +37,6 @@ $(document).ready(function() {
     $(".portlet-header").css("cursor", "auto");
 });
 
-var percentileThreshold = 0;
 var showControllersOnly = ${showControllersOnly?c!"false"};
 var seriesFilter = ${seriesFilter!"undefined"};
 var filtersOnlySampleSeries = ${filtersOnlySampleSeries?c!"false"};
@@ -264,13 +263,7 @@ var responseTimePercentilesInfos = {
         },
         createGraph: function() {
             var data = this.data;
-            var dataset = prepareData(data.result.series, $("#choicesResponseTimePercentiles"), function(series){
-                series.curvedLines = {apply: true, tension: 1};
-                series.threshold = {
-                        below: percentileThreshold,
-                        color: $("#slider-vertical").children("div").css("background-color")
-                };
-            });
+            var dataset = prepareData(data.result.series, $("#choicesResponseTimePercentiles"));
             var options = this.getOptions();
             prepareOptions(options, data);
             $.plot($("#flotResponseTimesPercentiles"), dataset, options);
@@ -1521,26 +1514,6 @@ function prepareData(series, choiceConta
     return datasets;
 }
 
-// create slider
-$(function() {
-    $( "#slider-vertical" ).slider({
-      orientation: "vertical",
-      range: "min",
-      min: responseTimePercentilesInfos.data.result.minY,
-      max: responseTimePercentilesInfos.data.result.maxY,
-      value: 0,
-      stop: function(event, ui ) {
-       percentileThreshold= ui.value;
-       refreshResponseTimePercentiles();
-       $("#amount").val(percentileThreshold);
-      }
-    });
-    $("#amount" ).val( $( "#slider-vertical" ).slider( "value" ) );
-    $("#slider-vertical").children("div").css("background-color","purple");
-    $("#amount" ).css("color", $("#slider-vertical").children("div").css("background-color"));
-    $("#slider-vertical").children("div").css("opacity","0.3");
-});
-
 /*
  * Ignore case comparator
  */

Modified: jmeter/trunk/bin/report-template/content/pages/ResponseTimes.html.fmkr
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/report-template/content/pages/ResponseTimes.html.fmkr?rev=1760160&r1=1760159&r2=1760160&view=diff
==============================================================================
--- jmeter/trunk/bin/report-template/content/pages/ResponseTimes.html.fmkr (original)
+++ jmeter/trunk/bin/report-template/content/pages/ResponseTimes.html.fmkr Sat Sep 10 13:20:02 2016
@@ -179,14 +179,13 @@
                         <!-- /.panel-heading -->
                         <div class="collapse in portlet-content" id="bodyResponseTimePercentiles">
                             <div class="panel-body" id="collapseResponseTimePercentiles">
-                                <div class="flot-chart col-lg-11 col-md-11 col-sm-11 col-xs-12">
+                                <div class="flot-chart">
                                     <div class="flot-chart-content" id="flotResponseTimesPercentiles" style="float: left; width:80%;"></div>
                                     <div style="float:left;margin-left:5px">
                                         <p>Zoom :</p>
                                         <div id="overviewResponseTimesPercentiles" style="width:190px;height:100px;"></div>
                                     </div>
                                 </div>
-                                <div class="col-lg-1 col-md-1 col-sm-1 hidden-xs"><div id="slider-vertical" style="height:342px;margin-top:9px;margin-right:auto;margin-left:auto;"></div><input type="text" id="amount" disabled style="width:100%;text-align:center;margin-top:20px"></div>
                             </div>
                             <div class="panel-footer" id="footerPercentiles">
                                 <p id="legendResponseTimePercentiles" hidden></p>

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1760160&r1=1760159&r2=1760160&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 10 13:20:02 2016
@@ -213,6 +213,7 @@ Summary
     <li><bug>60103</bug>Report / Dashboard : Requests summary includes Transaction Controller leading to wrong percentage</li>
     <li><bug>60105</bug>Report / Dashboard : Report requires Transaction Controller "generate parent sample" option to be checked , fix related issues</li>
     <li><bug>60107</bug>Report / Dashboard : In StatisticSummary, TransactionController SampleResult makes Total line wrong</li>
+    <li><bug>60110</bug>Report / Dashboard : In Response Time Percentiles, slider is useless</li>
 </ul>
 
  <!--  =================== Thanks =================== -->