You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/06/25 04:53:02 UTC

[GitHub] [ratis] szetszwo commented on a change in pull request #483: RATIS-1384.Change pending request limit unit to MB

szetszwo commented on a change in pull request #483:
URL: https://github.com/apache/ratis/pull/483#discussion_r658471467



##########
File path: ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -109,6 +109,18 @@ static SizeInBytes byteLimit(RaftProperties properties) {
     static void setByteLimit(RaftProperties properties, SizeInBytes byteLimit) {
       setSizeInBytes(properties::set, BYTE_LIMIT_KEY, byteLimit, requireMin(1L));
     }
+
+    String MEGA_BYTE_LIMIT_KEY = PREFIX + ".megabyte-limit";

Review comment:
       Let's reuse BYTE_LIMIT_KEY.  Otherwise, it is confusing to have two keys.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org