[GitHub] [incubator-superset] nytai commented on a change in pull request #11687: feat(dashboard): change dashboard edit action

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #11687:
URL: https://github.com/apache/incubator-superset/pull/11687#discussion_r537877759



##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -67,13 +67,11 @@ function DashboardCard({
 
   const menu = (
     <Menu>
-      {canEdit && openDashboardEditModal && (
+      {canEdit && handleDashboardEdit && (
         <Menu.Item
           role="button"
           tabIndex={0}
-          onClick={() =>
-            openDashboardEditModal && openDashboardEditModal(dashboard)
-          }
+          onClick={() => handleDashboardEdit && handleDashboardEdit(dashboard)}

Review comment:
       switched to using `<a />` but left out `target="_blank"` has users can achieve the same result with `CMD + click` or OS equivalent 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org