You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2018/08/21 14:16:35 UTC

[4/8] hbase git commit: HBASE-21074 JDK7 builds need to be done with TLSv1.2.

HBASE-21074 JDK7 builds need to be done with TLSv1.2.

Signed-off-by: Michael Stack <st...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1a477b11
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1a477b11
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1a477b11

Branch: refs/heads/branch-1.2
Commit: 1a477b115419bfcf21e3ff2b5a693738c4542c8e
Parents: 7e473dd
Author: Sean Busbey <bu...@apache.org>
Authored: Sun Aug 19 22:29:46 2018 -0500
Committer: Sean Busbey <bu...@apache.org>
Committed: Tue Aug 21 09:05:38 2018 -0500

----------------------------------------------------------------------
 dev-support/hbase-personality.sh             | 3 +++
 dev-support/hbase_nightly_source-artifact.sh | 3 ++-
 src/main/asciidoc/_chapters/developer.adoc   | 4 ++++
 3 files changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/1a477b11/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 1b313f4..df65c43 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -115,6 +115,9 @@ function personality_modules
   clear_personality_queue
 
   extra="-DHBasePatchProcess"
+  if [[ "${PATCH_BRANCH}" = branch-1* ]]; then
+    extra="${extra} -Dhttps.protocols=TLSv1.2"
+  fi
 
   if [[ -n "${HADOOP_PROFILE}" ]]; then
     extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"

http://git-wip-us.apache.org/repos/asf/hbase/blob/1a477b11/dev-support/hbase_nightly_source-artifact.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase_nightly_source-artifact.sh b/dev-support/hbase_nightly_source-artifact.sh
index 9458324..f3655e0 100755
--- a/dev-support/hbase_nightly_source-artifact.sh
+++ b/dev-support/hbase_nightly_source-artifact.sh
@@ -172,7 +172,8 @@ fi
 
 cd "${unpack_dir}"
 echo "Follow the ref guide section on making a RC: Step 8 Build the binary tarball."
-if mvn -DskipTests -Prelease --batch-mode -Dmaven.repo.local="${m2_tarbuild}" clean install \
+# N.B. Older JDK7 requires the TLSv1.2 in order to talk to maven central
+if mvn -Dhttps.protocols=TLSv1.2 -DskipTests -Prelease --batch-mode -Dmaven.repo.local="${m2_tarbuild}" clean install \
     assembly:single >"${working_dir}/srctarball_install.log" 2>&1; then
   echo "Building a binary tarball from the source tarball succeeded."
 else

http://git-wip-us.apache.org/repos/asf/hbase/blob/1a477b11/src/main/asciidoc/_chapters/developer.adoc
----------------------------------------------------------------------
diff --git a/src/main/asciidoc/_chapters/developer.adoc b/src/main/asciidoc/_chapters/developer.adoc
index e49143b..2c9631d 100644
--- a/src/main/asciidoc/_chapters/developer.adoc
+++ b/src/main/asciidoc/_chapters/developer.adoc
@@ -414,7 +414,11 @@ mvn -DskipTests package assembly:single deploy
 
 [[build.gotchas]]
 ==== Build Gotchas
+===== Failure to find dependencies with "protocol_version" error
 
+Many maven repositories, most notably Maven Central, now require TLSv1.2 for HTTPS connections. On older JDK7 instances you may need to manually add +-Dhttps.protocols=TLSv1.2+ to your Maven command line invocation.
+
+===== Maven Site failure
 If you see `Unable to find resource 'VM_global_library.vm'`, ignore it.
 It's not an error.
 It is link:http://jira.codehaus.org/browse/MSITE-286[officially